linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] locale.5: remove the FIXME for timezone
@ 2015-06-09 14:19 Marko Myllynen
       [not found] ` <5576F5E2.7050301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Marko Myllynen @ 2015-06-09 14:19 UTC (permalink / raw)
  To: Michael Kerrisk (man-pages); +Cc: linux-man

Hi Michael,

the timezone of LC_TIME is not in POSIX, only 6 (out of ~300)
glibc locales define it, the glibc code comment below from
glibc.git/programs/ld-time.c seems to suggest it's not a good
idea, and there's been a proposal in upstream [1] to remove the
existing timezone definitions from glibc locales so I think
it's actually better to leave this one undocumented:

/* XXX We don't perform any tests on the timezone value since this is
   simply useless, stupid $&$!@...  */

1) https://sourceware.org/ml/libc-alpha/2015-06/msg00098.html

Move the remaining LC_COLLATE FIXMEs together while at it.

---
 man5/locale.5 |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/man5/locale.5 b/man5/locale.5
index 2a2edc1..556c745 100644
--- a/man5/locale.5
+++ b/man5/locale.5
@@ -512,6 +512,10 @@ in the first column.
 
 The following keywords are allowed:
 .\" FIXME The following LC_COLLATE keywords are not documented:
+.\" 	reorder-after
+.\" 	reorder-end
+.\" 	reorder-sections-after
+.\" 	reorder-sections-end
 .\" 	script
 .\" 	symbol-equivalence
 .TP
@@ -534,11 +538,6 @@ or
 The order definition consists of lines that describe the order
 and is terminated with the keyword
 .IR order_end .
-.\" FIXME The following LC_COLLATE keywords are not documented:
-.\" 	reorder-after
-.\" 	reorder-end
-.\" 	reorder-sections-after
-.\" 	reorder-sections-end
 .PP
 The
 .B LC_COLLATE
@@ -1073,7 +1072,6 @@ The following keywords are allowed:
 .\"	era_d_fmt
 .\"	era_d_t_fmt
 .\"	era_t_fmt
-.\"	timezone
 .TP
 .I abday
 followed by a list of abbreviated names of the days of the week.

Thanks,

-- 
Marko Myllynen
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] locale.5: remove the FIXME for timezone
       [not found] ` <5576F5E2.7050301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2015-06-12 18:18   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2015-06-12 18:18 UTC (permalink / raw)
  To: myllynen-H+wXaHxf7aLQT0dZR+AlfA
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w, linux-man

On 06/09/2015 04:19 PM, Marko Myllynen wrote:
> Hi Michael,
> 
> the timezone of LC_TIME is not in POSIX, only 6 (out of ~300)
> glibc locales define it, the glibc code comment below from
> glibc.git/programs/ld-time.c seems to suggest it's not a good
> idea, and there's been a proposal in upstream [1] to remove the
> existing timezone definitions from glibc locales so I think
> it's actually better to leave this one undocumented:


Thanks, Marko. Applied.

Cheers,

Michael


> /* XXX We don't perform any tests on the timezone value since this is
>    simply useless, stupid $&$!@...  */
> 
> 1) https://sourceware.org/ml/libc-alpha/2015-06/msg00098.html
> 
> Move the remaining LC_COLLATE FIXMEs together while at it.
> 
> ---
>  man5/locale.5 |   10 ++++------
>  1 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/man5/locale.5 b/man5/locale.5
> index 2a2edc1..556c745 100644
> --- a/man5/locale.5
> +++ b/man5/locale.5
> @@ -512,6 +512,10 @@ in the first column.
>  
>  The following keywords are allowed:
>  .\" FIXME The following LC_COLLATE keywords are not documented:
> +.\" 	reorder-after
> +.\" 	reorder-end
> +.\" 	reorder-sections-after
> +.\" 	reorder-sections-end
>  .\" 	script
>  .\" 	symbol-equivalence
>  .TP
> @@ -534,11 +538,6 @@ or
>  The order definition consists of lines that describe the order
>  and is terminated with the keyword
>  .IR order_end .
> -.\" FIXME The following LC_COLLATE keywords are not documented:
> -.\" 	reorder-after
> -.\" 	reorder-end
> -.\" 	reorder-sections-after
> -.\" 	reorder-sections-end
>  .PP
>  The
>  .B LC_COLLATE
> @@ -1073,7 +1072,6 @@ The following keywords are allowed:
>  .\"	era_d_fmt
>  .\"	era_d_t_fmt
>  .\"	era_t_fmt
> -.\"	timezone
>  .TP
>  .I abday
>  followed by a list of abbreviated names of the days of the week.
> 
> Thanks,
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-12 18:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-09 14:19 [PATCH] locale.5: remove the FIXME for timezone Marko Myllynen
     [not found] ` <5576F5E2.7050301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-12 18:18   ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).