linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
To: "Michael Kerrisk (man-pages)"
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>
Subject: Re: [PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info
Date: Wed, 2 Dec 2015 16:40:46 -0500	[thread overview]
Message-ID: <565F655E.70707@hurleysoftware.com> (raw)
In-Reply-To: <565F4BEA.4050505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 12/02/2015 02:52 PM, Michael Kerrisk (man-pages) wrote:
> Hello Peter,
> 
> On 11/16/2015 10:39 PM, Peter Hurley wrote:
>> Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:
>>
>>     commit b3506a09d15dc5aee6d4bb88d759b157016e1864
>>     Author: Andries E. Brouwer <andries.brouwer-rh8NL+sEX9E@public.gmane.org>
>>     Date:   Tue Apr 1 04:42:46 2003 -0800
>>
>>     [PATCH] kill TIOCTTYGSTRUCT
>>
>>     Only used for (dubious) debugging purposes, and exposes
>>     internal kernel state.
>>
>> [The git SHA is from Thomas Gleixner's history tree at
>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]
> 
> Thanks for the report/patch. Man-pages tends to take a conservative
> approach about discarding stuff though, since people reading man pages
> also need to know about past behavior. Therefore, I instead
> just added a note that this ioctl() disappeared in Linux 2.5.67:
> "This command was removed in Linux 2.5.67."

Ok, thanks for the clarification.

I saw the commented-out TIOCGSERIAL/TIOCSSERIAL (which is _never_
going away) and assumed the policy was more best-practices than
complete.

Regards,
Peter Hurley

  
>> Signed-off-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
>> ---
>>  man4/tty_ioctl.4 | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/man4/tty_ioctl.4 b/man4/tty_ioctl.4
>> index 53645d8..c3bee35 100644
>> --- a/man4/tty_ioctl.4
>> +++ b/man4/tty_ioctl.4
>> @@ -471,14 +471,6 @@ For the
>>  .B TIOCLINUX
>>  ioctl, see
>>  .BR console_ioctl (4).
>> -.SS Kernel debugging
>> -.B "#include <linux/tty.h>"
>> -.TP
>> -.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
>> -Get the
>> -.I tty_struct
>> -corresponding to
>> -.IR fd .
>>  .\"
>>  .\" .SS Serial info
>>  .\" .BR "#include <linux/serial.h>"
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-02 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 21:39 [PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info Peter Hurley
     [not found] ` <1447709969-26477-1-git-send-email-peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-12-02 19:52   ` Michael Kerrisk (man-pages)
     [not found]     ` <565F4BEA.4050505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-02 21:40       ` Peter Hurley [this message]
     [not found]         ` <565F655E.70707-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-12-03 11:26           ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565F655E.70707@hurleysoftware.com \
    --to=peter-wagbzjegnqdsbiue7sb01tbpr1lh4cv8@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).