From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info Date: Thu, 03 Dec 2015 12:26:00 +0100 Message-ID: <566026C8.7030100@gmail.com> References: <1447709969-26477-1-git-send-email-peter@hurleysoftware.com> <565F4BEA.4050505@gmail.com> <565F655E.70707@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <565F655E.70707-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org> Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Hurley Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , Jiri Slaby List-Id: linux-man@vger.kernel.org On 12/02/2015 10:40 PM, Peter Hurley wrote: > On 12/02/2015 02:52 PM, Michael Kerrisk (man-pages) wrote: >> Hello Peter, >> >> On 11/16/2015 10:39 PM, Peter Hurley wrote: >>> Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by: >>> >>> commit b3506a09d15dc5aee6d4bb88d759b157016e1864 >>> Author: Andries E. Brouwer >>> Date: Tue Apr 1 04:42:46 2003 -0800 >>> >>> [PATCH] kill TIOCTTYGSTRUCT >>> >>> Only used for (dubious) debugging purposes, and exposes >>> internal kernel state. >>> >>> [The git SHA is from Thomas Gleixner's history tree at >>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git] >> >> Thanks for the report/patch. Man-pages tends to take a conservative >> approach about discarding stuff though, since people reading man pages >> also need to know about past behavior. Therefore, I instead >> just added a note that this ioctl() disappeared in Linux 2.5.67: >> "This command was removed in Linux 2.5.67." > > Ok, thanks for the clarification. > > I saw the commented-out TIOCGSERIAL/TIOCSSERIAL (which is _never_ > going away) and assumed the policy was more best-practices than > complete. Yes, things have not always been consistent, and TIOCTTYGSTRUCT is borderline. The change happened long enough ago now that I considered just applying you patch. Cheers Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html