[PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

[PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

[Peter Hurley]

Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:

    commit b3506a09d15dc5aee6d4bb88d759b157016e1864
    Author: Andries E. Brouwer <andries.brouwer-rh8NL+sEX9E@public.gmane.org>
    Date:   Tue Apr 1 04:42:46 2003 -0800

    [PATCH] kill TIOCTTYGSTRUCT

    Only used for (dubious) debugging purposes, and exposes
    internal kernel state.

[The git SHA is from Thomas Gleixner's history tree at
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]

Signed-off-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
---
 man4/tty_ioctl.4 | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/man4/tty_ioctl.4 b/man4/tty_ioctl.4
index 53645d8..c3bee35 100644
--- a/man4/tty_ioctl.4
+++ b/man4/tty_ioctl.4
@@ -471,14 +471,6 @@ For the
 .B TIOCLINUX
 ioctl, see
 .BR console_ioctl (4).
-.SS Kernel debugging
-.B "#include <linux/tty.h>"
-.TP
-.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
-Get the
-.I tty_struct
-corresponding to
-.IR fd .
 .\"
 .\" .SS Serial info
 .\" .BR "#include <linux/serial.h>"
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

[Michael Kerrisk (man-pages)]

Hello Peter,

On 11/16/2015 10:39 PM, Peter Hurley wrote:
> Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:
> 
>     commit b3506a09d15dc5aee6d4bb88d759b157016e1864
>     Author: Andries E. Brouwer <andries.brouwer-rh8NL+sEX9E@public.gmane.org>
>     Date:   Tue Apr 1 04:42:46 2003 -0800
> 
>     [PATCH] kill TIOCTTYGSTRUCT
> 
>     Only used for (dubious) debugging purposes, and exposes
>     internal kernel state.
> 
> [The git SHA is from Thomas Gleixner's history tree at
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]

Thanks for the report/patch. Man-pages tends to take a conservative
approach about discarding stuff though, since people reading man pages
also need to know about past behavior. Therefore, I instead
just added a note that this ioctl() disappeared in Linux 2.5.67:
"This command was removed in Linux 2.5.67."

Cheers,

Michael

 
> Signed-off-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
> ---
>  man4/tty_ioctl.4 | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/man4/tty_ioctl.4 b/man4/tty_ioctl.4
> index 53645d8..c3bee35 100644
> --- a/man4/tty_ioctl.4
> +++ b/man4/tty_ioctl.4
> @@ -471,14 +471,6 @@ For the
>  .B TIOCLINUX
>  ioctl, see
>  .BR console_ioctl (4).
> -.SS Kernel debugging
> -.B "#include <linux/tty.h>"
> -.TP
> -.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
> -Get the
> -.I tty_struct
> -corresponding to
> -.IR fd .
>  .\"
>  .\" .SS Serial info
>  .\" .BR "#include <linux/serial.h>"
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

[Peter Hurley]

On 12/02/2015 02:52 PM, Michael Kerrisk (man-pages) wrote:
> Hello Peter,
> 
> On 11/16/2015 10:39 PM, Peter Hurley wrote:
>> Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:
>>
>>     commit b3506a09d15dc5aee6d4bb88d759b157016e1864
>>     Author: Andries E. Brouwer <andries.brouwer-rh8NL+sEX9E@public.gmane.org>
>>     Date:   Tue Apr 1 04:42:46 2003 -0800
>>
>>     [PATCH] kill TIOCTTYGSTRUCT
>>
>>     Only used for (dubious) debugging purposes, and exposes
>>     internal kernel state.
>>
>> [The git SHA is from Thomas Gleixner's history tree at
>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]
> 
> Thanks for the report/patch. Man-pages tends to take a conservative
> approach about discarding stuff though, since people reading man pages
> also need to know about past behavior. Therefore, I instead
> just added a note that this ioctl() disappeared in Linux 2.5.67:
> "This command was removed in Linux 2.5.67."

Ok, thanks for the clarification.

I saw the commented-out TIOCGSERIAL/TIOCSSERIAL (which is _never_
going away) and assumed the policy was more best-practices than
complete.

Regards,
Peter Hurley

  
>> Signed-off-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
>> ---
>>  man4/tty_ioctl.4 | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/man4/tty_ioctl.4 b/man4/tty_ioctl.4
>> index 53645d8..c3bee35 100644
>> --- a/man4/tty_ioctl.4
>> +++ b/man4/tty_ioctl.4
>> @@ -471,14 +471,6 @@ For the
>>  .B TIOCLINUX
>>  ioctl, see
>>  .BR console_ioctl (4).
>> -.SS Kernel debugging
>> -.B "#include <linux/tty.h>"
>> -.TP
>> -.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
>> -Get the
>> -.I tty_struct
>> -corresponding to
>> -.IR fd .
>>  .\"
>>  .\" .SS Serial info
>>  .\" .BR "#include <linux/serial.h>"
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

[Michael Kerrisk (man-pages)]

On 12/02/2015 10:40 PM, Peter Hurley wrote:
> On 12/02/2015 02:52 PM, Michael Kerrisk (man-pages) wrote:
>> Hello Peter,
>>
>> On 11/16/2015 10:39 PM, Peter Hurley wrote:
>>> Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:
>>>
>>>     commit b3506a09d15dc5aee6d4bb88d759b157016e1864
>>>     Author: Andries E. Brouwer <andries.brouwer-rh8NL+sEX9E@public.gmane.org>
>>>     Date:   Tue Apr 1 04:42:46 2003 -0800
>>>
>>>     [PATCH] kill TIOCTTYGSTRUCT
>>>
>>>     Only used for (dubious) debugging purposes, and exposes
>>>     internal kernel state.
>>>
>>> [The git SHA is from Thomas Gleixner's history tree at
>>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]
>>
>> Thanks for the report/patch. Man-pages tends to take a conservative
>> approach about discarding stuff though, since people reading man pages
>> also need to know about past behavior. Therefore, I instead
>> just added a note that this ioctl() disappeared in Linux 2.5.67:
>> "This command was removed in Linux 2.5.67."
> 
> Ok, thanks for the clarification.
> 
> I saw the commented-out TIOCGSERIAL/TIOCSSERIAL (which is _never_
> going away) and assumed the policy was more best-practices than
> complete.

Yes, things have not always been consistent, and TIOCTTYGSTRUCT
is borderline. The change happened long enough ago now that
I considered just applying you patch.

Cheers

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html