[patch] rcmd.3: Add missing condition concerning .rhosts file

[patch] rcmd.3: Add missing condition concerning .rhosts file

[Nikola Forró]

The list of conditions determining if iruserok() and ruserok()
functions automatically fail is incomplete. According to glibc
source code, the functions also fail if the .rhosts file
is hardlinked anywhere.
---
 man3/rcmd.3 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man3/rcmd.3 b/man3/rcmd.3
index 33eae3c..f32fe52 100644
--- a/man3/rcmd.3
+++ b/man3/rcmd.3
@@ -200,8 +200,8 @@ in the local user's home directory is checked to see if the request for
 service is allowed.
 .PP
 If this file does not exist, is not a regular file, is owned by anyone
-other than the user or the superuser, or is writable by anyone other
-than the owner, the check automatically fails.
+other than the user or the superuser, is writable by anyone other
+than the owner, or is hardlinked anywhere, the check automatically fails.
 Zero is returned if the machine name is listed in the
 .IR hosts.equiv
 file, or the host and remote username are found in the
-- 
2.4.3


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] rcmd.3: Add missing condition concerning .rhosts file

[Michael Kerrisk (man-pages)]

Hello Nikola,

On 01/04/2016 05:18 PM, Nikola Forró wrote:
> The list of conditions determining if iruserok() and ruserok()
> functions automatically fail is incomplete. According to glibc
> source code, the functions also fail if the .rhosts file
> is hardlinked anywhere.

Just to better document the patch, could you point to the 
relevant location in the glibc source code?

Thanks,

Michael

> ---
>  man3/rcmd.3 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man3/rcmd.3 b/man3/rcmd.3
> index 33eae3c..f32fe52 100644
> --- a/man3/rcmd.3
> +++ b/man3/rcmd.3
> @@ -200,8 +200,8 @@ in the local user's home directory is checked to see if the request for
>  service is allowed.
>  .PP
>  If this file does not exist, is not a regular file, is owned by anyone
> -other than the user or the superuser, or is writable by anyone other
> -than the owner, the check automatically fails.
> +other than the user or the superuser, is writable by anyone other
> +than the owner, or is hardlinked anywhere, the check automatically fails.
>  Zero is returned if the machine name is listed in the
>  .IR hosts.equiv
>  file, or the host and remote username are found in the
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] rcmd.3: Add missing condition concerning .rhosts file

[Nikola Forró]

On Fri, 2016-01-08 at 17:24 +0100, Michael Kerrisk (man-pages) wrote:
> Just to better document the patch, could you point to the
> relevant location in the glibc source code?
> 
Sure. It's iruserfopen function in inet/rcmd.c [1].

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=inet/rcmd.c;hb=HEA
D#l465
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] rcmd.3: Add missing condition concerning .rhosts file

[Nikola Forró]

On Mon, 2016-01-11 at 11:06 +0100, Nikola Forró wrote:
> Sure. It's iruserfopen function in inet/rcmd.c [1].
> 
Sorry, fixed link:
[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=inet/rcmd.c;hb=HEAD#l465

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] rcmd.3: Add missing condition concerning .rhosts file

[Michael Kerrisk (man-pages)]

On 01/04/2016 05:18 PM, Nikola Forró wrote:
> The list of conditions determining if iruserok() and ruserok()
> functions automatically fail is incomplete. According to glibc
> source code, the functions also fail if the .rhosts file
> is hardlinked anywhere.

Thanks, Nikola. Applied.

Cheers,

Michael


> ---
>  man3/rcmd.3 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man3/rcmd.3 b/man3/rcmd.3
> index 33eae3c..f32fe52 100644
> --- a/man3/rcmd.3
> +++ b/man3/rcmd.3
> @@ -200,8 +200,8 @@ in the local user's home directory is checked to see if the request for
>  service is allowed.
>  .PP
>  If this file does not exist, is not a regular file, is owned by anyone
> -other than the user or the superuser, or is writable by anyone other
> -than the owner, the check automatically fails.
> +other than the user or the superuser, is writable by anyone other
> +than the owner, or is hardlinked anywhere, the check automatically fails.
>  Zero is returned if the machine name is listed in the
>  .IR hosts.equiv
>  file, or the host and remote username are found in the
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html