Re: [patch] keyctl.2: tfix

Re: [patch] keyctl.2: tfix

[Michael Kerrisk (man-pages)]

On 01/19/2016 11:18 PM, Joe Stein wrote:
> Signed-off-by: Joe Stein <joeaarons-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks, Joe. Applied.

Cheers,

Michael


> diff --git a/man2/keyctl.2 b/man2/keyctl.2
> index 8a9cb9b..8d706af 100644
> --- a/man2/keyctl.2
> +++ b/man2/keyctl.2
> @@ -98,7 +98,7 @@ Assume authority to instantiate key.
>  .P
>  These are wrapped by
>  .B libkeyutils
> -into individual functions to permit compiler the compiler to check types.
> +into individual functions to permit the compiler to check types.
>  See the
>  .B See Also
>  section at the bottom.
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] keyctl.2: tfix

[Arusekk]

Fixes: fa76da808eff
---
 man2/keyctl.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/keyctl.2 b/man2/keyctl.2
index 8930fb78b..4fa54bc14 100644
--- a/man2/keyctl.2
+++ b/man2/keyctl.2
@@ -33,7 +33,7 @@ keyctl \- manipulate the kernel's key management facility
 .B #include <sys/types.h>
 .B #include <keyutils.h>
 .PP
-.BI "long keyctl(int " operation ", ...)"
+.BI "long keyctl(int " operation ", ...);"
 
 .B "/* For direct call via syscall(2): */"
 .B #include <asm/unistd.h>
-- 
2.29.2

Re: [PATCH] keyctl.2: tfix

[Alejandro Colomar (man-pages)]

Hi Arusekk,

On 12/1/20 12:22 PM, Arusekk wrote:
> Fixes: fa76da808eff
> ---

Patch applied.  And thanks for noting the commit!

Thanks,

Alex

>  man2/keyctl.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/keyctl.2 b/man2/keyctl.2
> index 8930fb78b..4fa54bc14 100644
> --- a/man2/keyctl.2
> +++ b/man2/keyctl.2
> @@ -33,7 +33,7 @@ keyctl \- manipulate the kernel's key management facility
>  .B #include <sys/types.h>
>  .B #include <keyutils.h>
>  .PP
> -.BI "long keyctl(int " operation ", ...)"
> +.BI "long keyctl(int " operation ", ...);"
>  
>  .B "/* For direct call via syscall(2): */"
>  .B #include <asm/unistd.h>
> 

[PATCH] keyctl.2: tfix

[Alejandro Colomar]

From: Arusekk <arek_koz@o2.pl>

Fixes: fa76da808eff

Signed-off-by: Arusekk <arek_koz@o2.pl>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man2/keyctl.2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/keyctl.2 b/man2/keyctl.2
index 8930fb78b..4fa54bc14 100644
--- a/man2/keyctl.2
+++ b/man2/keyctl.2
@@ -33,7 +33,7 @@ keyctl \- manipulate the kernel's key management facility
 .B #include <sys/types.h>
 .B #include <keyutils.h>
 .PP
-.BI "long keyctl(int " operation ", ...)"
+.BI "long keyctl(int " operation ", ...);"
 
 .B "/* For direct call via syscall(2): */"
 .B #include <asm/unistd.h>
-- 
2.29.2

Re: [PATCH] keyctl.2: tfix

[Michael Kerrisk (man-pages)]

Hi Alex,

On 12/1/20 3:40 PM, Alejandro Colomar wrote:
> From: Arusekk <arek_koz@o2.pl>
> 
> Fixes: fa76da808eff
> 
> Signed-off-by: Arusekk <arek_koz@o2.pl>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Arusekk sent this patch twice. I applied the first version in my local tree,
but this version of the patch has a better commit message, so I dropped the 
old patch and applied this version instead.

Thanks,

Michael
> ---
>  man2/keyctl.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/keyctl.2 b/man2/keyctl.2
> index 8930fb78b..4fa54bc14 100644
> --- a/man2/keyctl.2
> +++ b/man2/keyctl.2
> @@ -33,7 +33,7 @@ keyctl \- manipulate the kernel's key management facility
>  .B #include <sys/types.h>
>  .B #include <keyutils.h>
>  .PP
> -.BI "long keyctl(int " operation ", ...)"
> +.BI "long keyctl(int " operation ", ...);"
>  
>  .B "/* For direct call via syscall(2): */"
>  .B #include <asm/unistd.h>
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH] keyctl.2: tfix

[Alejandro Colomar (man-pages)]

Hi Michael,

On 12/1/20 8:48 PM, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
> 
> On 12/1/20 3:40 PM, Alejandro Colomar wrote:
>> From: Arusekk <arek_koz@o2.pl>
>>
>> Fixes: fa76da808eff
>>
>> Signed-off-by: Arusekk <arek_koz@o2.pl>
>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> 
> Arusekk sent this patch twice. I applied the first version in my local tree,
> but this version of the patch has a better commit message, so I dropped the 
> old patch and applied this version instead.

Are you sure?
I only see one patch from him.
If you're seeing it on lore,
you're probably seeing it repeated because it
shows similar emails on the same thread even if unrelated
(which I agree, causes some unnecessary confusion).

The only patch I see from Arusekk is:
Message-Id: <20201201112245.11764-1-arek_koz@o2.pl>
which has this same commit msg, but without the signature, which I added.

BTW, thanks for reviewing the other thread!

Thanks,

Alex

> 
> Thanks,
> 
> Michael
>> ---
>>  man2/keyctl.2 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/man2/keyctl.2 b/man2/keyctl.2
>> index 8930fb78b..4fa54bc14 100644
>> --- a/man2/keyctl.2
>> +++ b/man2/keyctl.2
>> @@ -33,7 +33,7 @@ keyctl \- manipulate the kernel's key management facility
>>  .B #include <sys/types.h>
>>  .B #include <keyutils.h>
>>  .PP
>> -.BI "long keyctl(int " operation ", ...)"
>> +.BI "long keyctl(int " operation ", ...);"
>>  
>>  .B "/* For direct call via syscall(2): */"
>>  .B #include <asm/unistd.h>
>>
> 
> 

Re: [PATCH] keyctl.2: tfix

[Michael Kerrisk (man-pages)]

Hi Alex,

On 12/1/20 10:33 PM, Alejandro Colomar (man-pages) wrote:
> Hi Michael,
> 
> On 12/1/20 8:48 PM, Michael Kerrisk (man-pages) wrote:
>> Hi Alex,
>>
>> On 12/1/20 3:40 PM, Alejandro Colomar wrote:
>>> From: Arusekk <arek_koz@o2.pl>
>>>
>>> Fixes: fa76da808eff
>>>
>>> Signed-off-by: Arusekk <arek_koz@o2.pl>
>>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>>
>> Arusekk sent this patch twice. I applied the first version in my local tree,
>> but this version of the patch has a better commit message, so I dropped the 
>> old patch and applied this version instead.
> 
> Are you sure?
> I only see one patch from him.

I see now that the other patch was sent to me off-list...

> If you're seeing it on lore,
> you're probably seeing it repeated because it
> shows similar emails on the same thread even if unrelated
> (which I agree, causes some unnecessary confusion).
> 
> The only patch I see from Arusekk is:
> Message-Id: <20201201112245.11764-1-arek_koz@o2.pl>
> which has this same commit msg, but without the signature, which I added.
> 
> BTW, thanks for reviewing the other thread!

Sorry that I missed reviewing it earlier....

Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/