From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Weimer Subject: Re: [PATCH] Fix readdir_r with long file names Date: Wed, 2 Mar 2016 00:44:10 +0100 Message-ID: <56D6294A.5040703@redhat.com> References: <51B0B39F.4060202@redhat.com> <51B0BD36.3030202@redhat.com> <20130607013024.GO29800@brightrain.aerifal.cx> <51B19203.3070307@redhat.com> <20130607144143.GQ29800@brightrain.aerifal.cx> <51B57E35.4080403@redhat.com> <51B65EA7.2020402@redhat.com> <20130611011324.GT29800@brightrain.aerifal.cx> <51B8702D.2060505@redhat.com> <20130813040038.GE21795@spoyarek.pnq.redhat.com> <520C88A6.9070501@redhat.com> <56D54DAD.1040306@gmail.com> <56D5CA79.9030204@redhat.com> <56D5F832.3070209@gmail.com> <56D5FB3D.5000306@redhat.com> <56D607BB.6080701@cs.ucla.edu> <56D614AA.7020500@redhat.com> <56D61A86.3050108@cs.ucla.edu> <56D620AA.40108@redhat.com> <56D624FE.1090702@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56D624FE.1090702-764C0pRuGfqVc3sceRu5cw@public.gmane.org> Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Eggert , "Michael Kerrisk (man-pages)" , Siddhesh Poyarekar Cc: Rich Felker , Carlos O'Donell , KOSAKI Motohiro , libc-alpha , Roland McGrath , linux-man List-Id: linux-man@vger.kernel.org On 03/02/2016 12:25 AM, Paul Eggert wrote: >> And at the cost of >> changing sizeof (struct dirent), which can't be a good thing. > > Any program that depends on sizeof (struct dirent) is broken already, so > this isn't that worrisome. Just to be clear, you looked at the wrong struct dirent definition for GNU/Linux, there is a sysdeps override. Right now, most programs relying on sizeof (struct dirent) work well in almost all cases. We really don't want to break that. There appears to be an overlap between these programs and users of readdir_r, so once we remove that from the API, we should have better story for struct dirent declarators as well. Florian -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html