public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: aarch64 clone() man page omission
Date: Mon, 9 May 2016 22:40:24 +0100	[thread overview]
Message-ID: <573103C8.9050008@canonical.com> (raw)
In-Reply-To: <20160509213140.GD26300-UgUKS2FnFs9+urZeOPWqwQ@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1429 bytes --]

On 09/05/16 22:31, Mike Frysinger wrote:
> On 25 Apr 2016 20:42, Colin Ian King wrote:
>> currently, the aarch64 clone() system call requires the stack to be
>> aligned at a 16 byte boundary, see arch/arm64/kernel/process.c,
>> copy_thread():
>>
>>                 if (stack_start) {
>>                         if (is_compat_thread(task_thread_info(p)))
>>                                 childregs->compat_sp = stack_start;
>>                         /* 16-byte aligned stack mandatory on AArch64 */
>>                         else if (stack_start & 15)
>>                                 return -EINVAL;
>>                         else
>>                                 childregs->sp = stack_start;
>>                 }
>>
>>
>> ..and returns -EINVAL if not aligned correctly.  This should be added to
>> the manual page clone(2) as it took me a while to figure out why clone()
>> was failing with -EINVAL for aarch64 but not on x86.
> 
> seems weird for the kernel to be enforcing this.  is it just because of
> the stated ABI ?  or is there some weird requirement in the kernel itself
> that requires this ?  it's not like other arches have this check, and
> there are def ABI requirements about stack alignments in C.
> -mike
> 
The article here indicates it is an aarch64 convention:

https://community.arm.com/groups/processors/blog/2015/11/19/using-the-stack-in-aarch32-and-aarch64





[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-05-09 21:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 19:42 aarch64 clone() man page omission Colin Ian King
     [not found] ` <571E731A.6050809-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-05-09 21:01   ` Michael Kerrisk (man-pages)
2016-05-09 21:31   ` Mike Frysinger
     [not found]     ` <20160509213140.GD26300-UgUKS2FnFs9+urZeOPWqwQ@public.gmane.org>
2016-05-09 21:40       ` Colin Ian King [this message]
     [not found]         ` <573103C8.9050008-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-05-11  2:50           ` Mike Frysinger
     [not found]             ` <20160511025040.GL26300-UgUKS2FnFs9+urZeOPWqwQ@public.gmane.org>
2016-05-11 13:18               ` Catalin Marinas
     [not found]                 ` <20160511131855.GG3051-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2016-05-11 13:33                   ` Colin Ian King
     [not found]                     ` <5733348D.7010301-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-05-11 15:22                       ` Catalin Marinas
     [not found]                         ` <20160511152249.GI3051-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2016-05-11 15:25                           ` Colin Ian King
2016-05-11 14:00                   ` Mike Frysinger
     [not found]                     ` <20160511140024.GM26300-UgUKS2FnFs9+urZeOPWqwQ@public.gmane.org>
2016-05-11 15:26                       ` Catalin Marinas
     [not found]                         ` <20160511152622.GJ3051-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2016-05-11 16:27                           ` Mike Frysinger
     [not found]                             ` <20160511162751.GN26300-UgUKS2FnFs9+urZeOPWqwQ@public.gmane.org>
2016-05-11 16:36                               ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573103C8.9050008@canonical.com \
    --to=colin.king-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox