From: walter harms <wharms-fPG8STNUNVg@public.gmane.org>
To: Kees Cook <keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: linux-man <linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: IPPROTO_ICMP
Date: Sat, 03 Dec 2016 13:43:16 +0100 [thread overview]
Message-ID: <5842BDE4.3010204@bfs.de> (raw)
In-Reply-To: <CAGXu5jLwj7p_ueaz-vEH_MJLC_xxwpXUT_GFLAnMOvdh7HUxmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am 03.12.2016 05:58, schrieb Kees Cook:
> Hi,
>
> So, while playing with IPPROTO_ICMP[1], I rediscovered the sysctl
> needed to use it, and went to make sure that it was covered in the
> man-pages. It is, in man.7 (ping_group_range), though there is no
> mention of IPPROTO_ICMP there. Also, it seems that socket.2 says to
> either look at protocols.5 (which just talks about the file) or ip.7
> for AF_INET. ip.7 says:
>
> udp_socket = socket(AF_INET, SOCK_DGRAM, 0);
>
> And continues to make assumptions that IPPROTO_ICMP doesn't exist:
> "SOCK_DGRAM to open a udp(7) socket", "The only valid values for
> protocol are ... 0 and IPPROTO_UDP", etc. Additionally, EACCESS is
> missing the error condition for not having ping_group_range set
> correctly.
>
> Does it make sense to put IPPROTO_ICMP details in ip.7? Or is there a
> better place to list it? Are there additional details beyond what I
> pointed out that should be updated in ip.7?
>
> Thanks!
>
> -Kees
>
> [1] https://lwn.net/Articles/443051/
>
Interesting, i have never heard about it.
But i would suggest this as a special chapter in ICMP(7).
When I would search for information about ping, i would go to icmp
not to IP.
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-03 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 4:58 IPPROTO_ICMP Kees Cook
[not found] ` <CAGXu5jLwj7p_ueaz-vEH_MJLC_xxwpXUT_GFLAnMOvdh7HUxmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-03 12:43 ` walter harms [this message]
[not found] ` <5842BDE4.3010204-fPG8STNUNVg@public.gmane.org>
2016-12-03 14:15 ` IPPROTO_ICMP Michael Kerrisk (man-pages)
[not found] ` <5e52b0bd-6465-7432-8e79-3c835627d73d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-03 20:06 ` IPPROTO_ICMP Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5842BDE4.3010204@bfs.de \
--to=wharms-fpg8stnunvg@public.gmane.org \
--cc=keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox