Re: [PATCH 2/9] system_data_types.7: srcfix: Add FIXME note: Add descriptions

Alejandro Colomar
2020-09-18T21:35:46Z

Hi Michael,

On 2020-09-18 23:03, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
>
> On 9/18/20 10:50 PM, Michael Kerrisk (man-pages) wrote:
>> On 9/18/20 7:04 PM, Alejandro Colomar wrote:
>>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>>
>>
>> Thanks, Alex. Patch applied.
>
> Sorry -- I misspoke. This pach doesn't apply. It wasn't obvious why.
>
> But, yes, I think adding a description would be good.
>
> Thanks,
>
> Michael
>
>>> ---
>>> man7/system_data_types.7 | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
>>> index 5352f3ef2..48871e4eb 100644
>>> --- a/man7/system_data_types.7
>>> +++ b/man7/system_data_types.7
>>> @@ -96,6 +96,8 @@ typedef struct {
>>> * the end of substring */
>>> } regmatch_t;
>>> .EE
>>> +.\".IP
>>> +.\" FIXME: Add a description?
>>> .IP
>>> Conforming to: POSIX.1-2001 and later.
>>> .IP

I added that comment to every type that lacks a description so that we
can see them easier. In other types I embedded that comment in the
patch with the documentation, but in this case, the type was already
documented, so I had to add an extra commit.

Cheers,

Alex