public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Dan Robertson <dan@dlrobertson.com>
Cc: djwong@kernel.org, mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH 0/1] man2/fallocate.2: Fix documentation of shared blocks
Date: Sat, 3 Jul 2021 20:18:50 +0200	[thread overview]
Message-ID: <68fe16f4-9ec2-54a8-056a-c2239d8c8cfb@gmail.com> (raw)
In-Reply-To: <20210621004453.7437-1-dan@dlrobertson.com>

Hi Dan,

On 6/21/21 2:44 AM, Dan Robertson wrote:
> While doing some work on fallocate for bcachefs I think I stumbled on a
> typo in the fallocate man page. FALLOC_FL_UNSHARE should be
> FALLOC_FL_UNSHARE_RANGE. I believe this is a typo instead of an update
> as a brief look at git history in the kernel seems to indicate that the
> flag was never previously FALLOC_FL_UNSHARE.
> 
> If I missed something in my review of history, please let me know. Any
> feedback would be welcome :)

You seem to be correct.  There are 2 commits that talk about
FALLOC_FL_UNSHARE, but it seems that they do so for simplicity, and the
code only contains FALLOC_FL_UNSHARE_RANGE.

I applied the patch.

Thanks,

Alex

> 
> Dan Robertson (1):
>   man2/fallocate.2: tfix documentation of shared blocks
> 
>  man2/fallocate.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

      parent reply	other threads:[~2021-07-03 18:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21  0:44 [PATCH 0/1] man2/fallocate.2: Fix documentation of shared blocks Dan Robertson
2021-06-21  0:44 ` [PATCH 1/1] man2/fallocate.2: tfix " Dan Robertson
2021-06-21  4:25   ` Darrick J. Wong
2021-06-28 13:13     ` Dan Robertson
2021-07-03 18:20     ` Alejandro Colomar (man-pages)
2021-07-03 18:26     ` Alejandro Colomar (man-pages)
2021-07-03 20:09       ` Dan Robertson
2021-07-03 21:31         ` Alejandro Colomar (man-pages)
2021-07-03 22:55           ` Dan Robertson
2021-07-04 11:27             ` Alejandro Colomar (man-pages)
2021-07-03 18:18 ` Alejandro Colomar (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68fe16f4-9ec2-54a8-056a-c2239d8c8cfb@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=dan@dlrobertson.com \
    --cc=djwong@kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox