* [patch] recv.2: correct non-existent name msg_iovec
@ 2023-06-19 11:49 Rob Linden
2023-07-08 15:29 ` Alejandro Colomar
0 siblings, 1 reply; 3+ messages in thread
From: Rob Linden @ 2023-06-19 11:49 UTC (permalink / raw)
To: Alejandro Colomar; +Cc: linux-man
Hello Alejandro!
I think there is a mistake on the manpage for recv. In the description of
the flag MSG_ERRQUEUE it says that data is passed via "msg_iovec". This is
probably referring to msg_iov in struct msghdr
(from /usr/include/bits/socket.h). A "msg_iovec" doesn't seem to exist.
Maybe it was spelled wrong because it's of type struct iovec.
If it is indeed wrong then the following patch corrects it:
Signed-off-by: Rob Linden <rlinden@redhat.com>
From 830a1b1233eb69bd8a4a64296581d094fb0edc46 Mon Sep 17 00:00:00 2001
From: rokkbert <rokkbert@gmail.com>
Date: Tue, 6 Jun 2023 10:00:20 +0200
Subject: [PATCH] recv.2: field msg_iov in struct msghdr is wrongly called
msg_iovec. Corrected to msg_iov.
---
man2/recv.2 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man2/recv.2 b/man2/recv.2
index 27d6d612c..62e43c9aa 100644
--- a/man2/recv.2
+++ b/man2/recv.2
@@ -159,7 +159,7 @@ and
for more information.
The payload of the original packet that caused the error
is passed as normal data via
-.IR msg_iovec .
+.IR msg_iov .
The original destination address of the datagram that caused the error
is supplied via
.IR msg_name .
--
2.39.2
All the best,
rob
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] recv.2: correct non-existent name msg_iovec
2023-06-19 11:49 [patch] recv.2: correct non-existent name msg_iovec Rob Linden
@ 2023-07-08 15:29 ` Alejandro Colomar
2023-07-08 15:57 ` Alejandro Colomar
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Colomar @ 2023-07-08 15:29 UTC (permalink / raw)
To: Rob Linden; +Cc: linux-man
[-- Attachment #1.1: Type: text/plain, Size: 1694 bytes --]
On 6/19/23 13:49, Rob Linden wrote:
> Hello Alejandro!
Hello Rob!
Sorry for the delay; I've been on vacation. Please don't start new
threads for continuing an old one, as it makes it difficult to follow.
Is this just a resend of the previous patch?
Thanks,
Alex
>
> I think there is a mistake on the manpage for recv. In the description of
> the flag MSG_ERRQUEUE it says that data is passed via "msg_iovec". This is
> probably referring to msg_iov in struct msghdr
> (from /usr/include/bits/socket.h). A "msg_iovec" doesn't seem to exist.
> Maybe it was spelled wrong because it's of type struct iovec.
> If it is indeed wrong then the following patch corrects it:
>
> Signed-off-by: Rob Linden <rlinden@redhat.com>
>
> From 830a1b1233eb69bd8a4a64296581d094fb0edc46 Mon Sep 17 00:00:00 2001
> From: rokkbert <rokkbert@gmail.com>
> Date: Tue, 6 Jun 2023 10:00:20 +0200
> Subject: [PATCH] recv.2: field msg_iov in struct msghdr is wrongly called
> msg_iovec. Corrected to msg_iov.
>
> ---
> man2/recv.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/recv.2 b/man2/recv.2
> index 27d6d612c..62e43c9aa 100644
> --- a/man2/recv.2
> +++ b/man2/recv.2
> @@ -159,7 +159,7 @@ and
> for more information.
> The payload of the original packet that caused the error
> is passed as normal data via
> -.IR msg_iovec .
> +.IR msg_iov .
> The original destination address of the datagram that caused the error
> is supplied via
> .IR msg_name .
> --
> 2.39.2
>
>
> All the best,
> rob
>
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] recv.2: correct non-existent name msg_iovec
2023-07-08 15:29 ` Alejandro Colomar
@ 2023-07-08 15:57 ` Alejandro Colomar
0 siblings, 0 replies; 3+ messages in thread
From: Alejandro Colomar @ 2023-07-08 15:57 UTC (permalink / raw)
To: Rob Linden; +Cc: linux-man
[-- Attachment #1.1: Type: text/plain, Size: 1931 bytes --]
On 7/8/23 17:29, Alejandro Colomar wrote:
> On 6/19/23 13:49, Rob Linden wrote:
>> Hello Alejandro!
>
> Hello Rob!
>
> Sorry for the delay; I've been on vacation. Please don't start new
> threads for continuing an old one, as it makes it difficult to follow.
> Is this just a resend of the previous patch?
Can you please resend any patches that you sent as a new patch set, with
all of them together?
Thanks,
Alex
>
> Thanks,
> Alex
>
>>
>> I think there is a mistake on the manpage for recv. In the description of
>> the flag MSG_ERRQUEUE it says that data is passed via "msg_iovec".
>> This is
>> probably referring to msg_iov in struct msghdr
>> (from /usr/include/bits/socket.h). A "msg_iovec" doesn't seem to exist.
>> Maybe it was spelled wrong because it's of type struct iovec.
>> If it is indeed wrong then the following patch corrects it:
>>
>> Signed-off-by: Rob Linden <rlinden@redhat.com>
>>
>> From 830a1b1233eb69bd8a4a64296581d094fb0edc46 Mon Sep 17 00:00:00 2001
>> From: rokkbert <rokkbert@gmail.com>
>> Date: Tue, 6 Jun 2023 10:00:20 +0200
>> Subject: [PATCH] recv.2: field msg_iov in struct msghdr is wrongly called
>> msg_iovec. Corrected to msg_iov.
>>
>> ---
>> man2/recv.2 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/man2/recv.2 b/man2/recv.2
>> index 27d6d612c..62e43c9aa 100644
>> --- a/man2/recv.2
>> +++ b/man2/recv.2
>> @@ -159,7 +159,7 @@ and
>> for more information.
>> The payload of the original packet that caused the error
>> is passed as normal data via
>> -.IR msg_iovec .
>> +.IR msg_iov .
>> The original destination address of the datagram that caused the error
>> is supplied via
>> .IR msg_name .
>> --
>> 2.39.2
>>
>>
>> All the best,
>> rob
>>
>
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-08 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 11:49 [patch] recv.2: correct non-existent name msg_iovec Rob Linden
2023-07-08 15:29 ` Alejandro Colomar
2023-07-08 15:57 ` Alejandro Colomar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox