Re: [PATCH v6] grantpt.3: no-op on modern glibc and other UNIXes, HISTORYise

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2464 bytes --]

On 2023-07-18 17:07, наб wrote:
> On Tue, Jul 18, 2023 at 01:42:08PM +0200, Alejandro Colomar wrote:
>> On 2023-07-18 01:31, наб wrote:
>>> Also, administriva-wise, git pull tells me
>>>   [PATCH 1/2] statfs.2: unshade as deprecated, but direct to statvfs(3)
>>> with msgid
>>>   <b4b871ffdf8f764ffd6c25039f3944b08748bd3e.1687553930.git.nabijaczleweli@nabijaczleweli.xyz>
>>> is the last outstanding patch I have rn, sans this one.
>> I was waiting for you to send an v2 with the fs and inode corrections
>> suggested by Tom Schwindl.  Is that correct?
> You applied 2/2 but I got no responses for 1/2.
> Scissoring a rebased 1/2 below.
> 
> Update-wise: musl@ told me they basically agree and will apply it
> when glibc does, and I got the glibc first round of reviews and the
> hurd half stamped, but it's now entered the "resend every week to
> no response" stage that all glibc patches go through.
> 
> When those land I'll probably re-shade the declarations, turn the
> paragraph into "use the standard statvfs(3) interface instead, but
> see VERSIONS if using f_type" and extract the magicks to, like,
> fs-magic(7) or whatever.

Ok.  Thanks!

> 
> Best,
> -- >8 --
> Date: Fri, 23 Jun 2023 22:49:22 +0200
> Subject: [PATCH v2 1/2] statfs.2: Unshade as deprecated, but direct to statvfs(3)
> 
> Link: https://lore.kernel.org/linux-man/f54kudgblgk643u32tb6at4cd3kkzha6hslahv24szs4raroaz@ogivjbfdaqtb/t/#u
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

Patch applied.

Cheers,
Alex

> ---
>  man2/statfs.2 | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/statfs.2 b/man2/statfs.2
> index 0496ab6c9..307a29b3a 100644
> --- a/man2/statfs.2
> +++ b/man2/statfs.2
> @@ -15,9 +15,15 @@ .SH SYNOPSIS
>  .nf
>  .BR "#include <sys/vfs.h>    " "/* or <sys/statfs.h> */"
>  .PP
> -.BI "[[deprecated]] int statfs(const char *" path ", struct statfs *" buf );
> -.BI "[[deprecated]] int fstatfs(int " fd ", struct statfs *" buf );
> +.BI "int statfs(const char *" path ", struct statfs *" buf );
> +.BI "int fstatfs(int " fd ", struct statfs *" buf );
>  .fi
> +.PP
> +Unless you need the
> +.I f_type
> +field, you should use the standard
> +.BR statvfs (3)
> +interface instead.
>  .SH DESCRIPTION
>  The
>  .BR statfs ()

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]