Re: [PATCH RFC] statx.2: Add stx_atomic_write_unit_max_opt

John Garry
2025-04-04T09:23:28Z

On 04/04/2025 10:06, Christoph Hellwig wrote:
> On Thu, Apr 03, 2025 at 04:07:04PM +0100, John Garry wrote:
>> So I am thinking one of these:
>> a. stx_atomic_write_unit_max_dev
>> b. stx_atomic_write_unit_max_bdev
>> c. stx_atomic_write_unit_max_align
>> d. stx_atomic_write_unit_max_hw
>>
>> The terms dev (or device) and bdev are already used in the meaning of some
>> members in struct statx, so not too bad. However, when we support large
>> atomic writes for XFS rtvol, the bdev atomic write limit and rtextsize
>> would influence this value (so just bdev might be a bit misleading in the
>> name).
>
> Don't. Especially when you have a natively out of write file system
> that optimized case will not involve the usual hardware offload.
>
>
stx_atomic_write_unit_max_opt it is then.

Or stx_atomic_write_unit_max_optimal or stx_atomic_write_unit_max_fast.
Or similar..

cheers,
John