Re: [PATCH] mmap.2: ffix

[Alejandro Colomar <alx.mailinglists@gmail.com>]

Hi, Jakub and Branden!

On 11/12/21 11:39, Jakub Wilk wrote:
> '" type of behavior:' was incorrectly formatted in bold.

Thanks for the report!

> 
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
> ---
>  man2/mmap.2 | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/man2/mmap.2 b/man2/mmap.2
> index 96b7444b0..f6e406ed5 100644
> --- a/man2/mmap.2
> +++ b/man2/mmap.2
> @@ -289,8 +289,7 @@ Note that older kernels which do not recognize the
>  .BR MAP_FIXED_NOREPLACE
>  flag will typically (upon detecting a collision with a preexisting mapping)
>  fall back to a "non-\c
> -.B MAP_FIXED\c
> -" type of behavior:

Branden, why is that?  Is a leading '"' special here?

> +.BR MAP_FIXED "\(dq type of behavior:"

I'll apply a slightly simpler patch (removing \c):

diff --git a/man2/mmap.2 b/man2/mmap.2
index 30756f078..d0291be8e 100644
--- a/man2/mmap.2
+++ b/man2/mmap.2
@@ -271,9 +271,9 @@ one thread will succeed; all others will report failure.
 Note that older kernels which do not recognize the
 .BR MAP_FIXED_NOREPLACE
 flag will typically (upon detecting a collision with a preexisting mapping)
-fall back to a "non-\c
-.B MAP_FIXED\c
-" type of behavior:
+fall back to a
+.RB \(dqnon- MAP_FIXED \(dq
+type of behavior:
 they will return an address that is different from the requested address.
 Therefore, backward-compatible software
 should check the returned address against the requested address.



>  they will return an address that is different from the requested address.
>  Therefore, backward-compatible software
>  should check the returned address against the requested address.

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/