Re: [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_EXACT_ADDRESS

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1623 bytes --]

Hi Nadav,

On 3/14/22 13:23, Alejandro Colomar (man-pages) wrote:
> Hi Nadav,
> 
> On 3/7/22 19:48, Nadav Amit wrote:
>> From: Nadav Amit <namit@vmware.com>
>>
>> Describe the new UFFD_FEATURE_EXACT_ADDRESS API feature.
>>
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
> 
> LGTM.  Please ping when it's added to Linus's tree,
> and add a comment with the commit message that added it.

I've checked that this was finally added to the kernel.  Should I apply
the patch as is, or is there anything that was changed?

Cheers,

Alex

> 
> Thanks,
> 
> Alex
> 
>>  man2/ioctl_userfaultfd.2 | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
>> index 504f61d4b..94480158e 100644
>> --- a/man2/ioctl_userfaultfd.2
>> +++ b/man2/ioctl_userfaultfd.2
>> @@ -214,6 +214,14 @@ memory accesses to the regions registered with userfaultfd.
>>  If this feature bit is set,
>>  .I uffd_msg.pagefault.feat.ptid
>>  will be set to the faulted thread ID for each page-fault message.
>> +.TP
>> +.BR UFFD_FEATURE_EXACT_ADDRESS " (since Linux 5.18)"
>> +If this feature bit is set,
>> +.I uffd_msg.pagefault.address
>> +will be set to the exact page-fault address that was reported by the hardware,
>> +and will not mask the offset within the page.
>> +Note that old Linux versions might indicate the exact address as well,
>> +even though the feature bit is not set.
>>  .PP
>>  The returned
>>  .I ioctls
> 

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]