Re: [PATCH] splice.2: Use 'off64_t' instead of 'loff_t'

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hi Alex,

On 2/15/21 2:15 PM, Alejandro Colomar wrote:
> The kernel syscall uses 'loff_t', but the glibc wrapper uses 'off64_t'.
> Let's document the wrapper prototype, as in other pages.
> 
> ......
> 
> .../glibc$ grep_glibc_prototype splice
> sysdeps/unix/sysv/linux/bits/fcntl-linux.h:398:
> extern __ssize_t splice (int __fdin, __off64_t *__offin, int __fdout,
> 			 __off64_t *__offout, size_t __len,
> 			 unsigned int __flags);
> .../glibc$
> 
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Thanks! Patch applied.

Cheers,

Michael


> ---
>  man2/splice.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/splice.2 b/man2/splice.2
> index 6e9029281..d07639810 100644
> --- a/man2/splice.2
> +++ b/man2/splice.2
> @@ -31,8 +31,8 @@ splice \- splice data to/from a pipe
>  .BR "#define _GNU_SOURCE" "         /* See feature_test_macros(7) */"
>  .B #include <fcntl.h>
>  .PP
> -.BI "ssize_t splice(int " fd_in ", loff_t *" off_in ", int " fd_out ,
> -.BI "               loff_t *" off_out ", size_t " len \
> +.BI "ssize_t splice(int " fd_in ", off64_t *" off_in ", int " fd_out ,
> +.BI "               off64_t *" off_out ", size_t " len \
>  ", unsigned int " flags );
>  .\" Return type was long before glibc 2.7
>  .fi
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/