[PATCH] make consistent example in recv.2

[PATCH] make consistent example in recv.2

[Peter Radisson]

Replace 0 with NULL als in the example a few lines above
---
  man2/recv.2 | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man2/recv.2 b/man2/recv.2
index ba17d03a3..21f65e86f 100644
--- a/man2/recv.2
+++ b/man2/recv.2
@@ -325,7 +325,7 @@ socket (see
  .BR connect (2)).
  It is equivalent to the call:
  .PP
-    recvfrom(fd, buf, len, flags, NULL, 0);
+    recvfrom(fd, buf, len, flags, NULL, NULL);
  .\"
  .SS recvmsg()
  The
--
2.35.3

Re: [PATCH] make consistent example in recv.2

[Carlos O'Donell]

On 3/27/25 1:54 PM, Peter Radisson wrote:
> 
> Replace 0 with NULL als in the example a few lines above
> ---
>   man2/recv.2 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man2/recv.2 b/man2/recv.2
> index ba17d03a3..21f65e86f 100644
> --- a/man2/recv.2
> +++ b/man2/recv.2
> @@ -325,7 +325,7 @@ socket (see
>   .BR connect (2)).
>   It is equivalent to the call:
>   .PP
> -    recvfrom(fd, buf, len, flags, NULL, 0);
> +    recvfrom(fd, buf, len, flags, NULL, NULL);
>   .\"
>   .SS recvmsg()
>   The
> -- 
> 2.35.3

Agreed. They are both pointers. It should be "NULL, NULL".
It should also match the text under DESCRIPTION.

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.

Re: [PATCH] make consistent example in recv.2

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]

Hi Peter, Carlos,

On Fri, Mar 28, 2025 at 06:53:52PM -0400, Carlos O'Donell wrote:
> On 3/27/25 1:54 PM, Peter Radisson wrote:
> > 
> > Replace 0 with NULL als in the example a few lines above

Thanks!  I've applied the patch.

Although, I had to do it manually.  It seems you have an old copy of the
repository; you should pull the contents.

	warning: Patch sent with format=flowed; space at the end of lines might be lost.
	Applying: make consistent example in recv.2
	error: man2/recv.2: does not exist in index
	Patch failed at 0001 make consistent example in recv.2
	hint: Use 'git am --show-current-patch=diff' to see the failed patch
	hint: When you have resolved this problem, run "git am --continue".
	hint: If you prefer to skip this patch, run "git am --skip" instead.
	hint: To restore the original branch and stop patching, run "git am --abort".
	hint: Disable this message with "git config set advice.mergeConflict false"

> > ---
> >   man2/recv.2 | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/man2/recv.2 b/man2/recv.2
> > index ba17d03a3..21f65e86f 100644
> > --- a/man2/recv.2
> > +++ b/man2/recv.2
> > @@ -325,7 +325,7 @@ socket (see
> >   .BR connect (2)).
> >   It is equivalent to the call:
> >   .PP

This context was changed in
1ae6b2c7b818 (2022-03-20; "Many pages: Fix style issues reported by `make lint-groff`")

> > -    recvfrom(fd, buf, len, flags, NULL, 0);
> > +    recvfrom(fd, buf, len, flags, NULL, NULL);
> >   .\"
> >   .SS recvmsg()
> >   The
> > -- 
> > 2.35.3
> 
> Agreed. They are both pointers. It should be "NULL, NULL".
> It should also match the text under DESCRIPTION.
> 
> LGTM.
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Thanks!  I've appended your R-b tag.


Have a lovely day!
Alex

P.S.: Please use <alx@kernel.org>.  I don't use my @gmail account
      anymore.

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] make consistent example in recv.2

[Peter Radisson]

Am 29.03.25 um 19:30 schrieb Alejandro Colomar:
> Hi Peter, Carlos,
>
> On Fri, Mar 28, 2025 at 06:53:52PM -0400, Carlos O'Donell wrote:
>> On 3/27/25 1:54 PM, Peter Radisson wrote:
>>>
>>> Replace 0 with NULL als in the example a few lines above
>
> Thanks!  I've applied the patch.
>
> Although, I had to do it manually.  It seems you have an old copy of the
> repository; you should pull the contents.
>
This was not intentional
i have just checked my source was
  https://git.kernel.org/pub/scm/docs/man-pages/man-pages
but it seems i was accidently on the wrong branch


> 	warning: Patch sent with format=flowed; space at the end of lines might be lost.
> 	Applying: make consistent example in recv.2
> 	error: man2/recv.2: does not exist in index
> 	Patch failed at 0001 make consistent example in recv.2
> 	hint: Use 'git am --show-current-patch=diff' to see the failed patch
> 	hint: When you have resolved this problem, run "git am --continue".
> 	hint: If you prefer to skip this patch, run "git am --skip" instead.
> 	hint: To restore the original branch and stop patching, run "git am --abort".
> 	hint: Disable this message with "git config set advice.mergeConflict false"
>
>>> ---
>>>    man2/recv.2 | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/man2/recv.2 b/man2/recv.2
>>> index ba17d03a3..21f65e86f 100644
>>> --- a/man2/recv.2
>>> +++ b/man2/recv.2
>>> @@ -325,7 +325,7 @@ socket (see
>>>    .BR connect (2)).
>>>    It is equivalent to the call:
>>>    .PP
>
> This context was changed in
> 1ae6b2c7b818 (2022-03-20; "Many pages: Fix style issues reported by `make lint-groff`")
>
>>> -    recvfrom(fd, buf, len, flags, NULL, 0);
>>> +    recvfrom(fd, buf, len, flags, NULL, NULL);
>>>    .\"
>>>    .SS recvmsg()
>>>    The
>>> --
>>> 2.35.3
>>
>> Agreed. They are both pointers. It should be "NULL, NULL".
>> It should also match the text under DESCRIPTION.
>>
>> LGTM.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
> Thanks!  I've appended your R-b tag.
>
>
> Have a lovely day!
> Alex
>
> P.S.: Please use <alx@kernel.org>.  I don't use my @gmail account
>        anymore.
>