Re: [PATCH v3 5/6] man2/chmod.2: add C digit separators to clarify POSIX feature release dates and long numeric digit strings

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3293 bytes --]

Hi Brian,

On 2/15/23 21:17, Brian Inglis wrote:
> ---
>  man2/chmod.2 | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/man2/chmod.2 b/man2/chmod.2
> index 8b5db74ed7e3..674b54368314 100644
> --- a/man2/chmod.2
> +++ b/man2/chmod.2
> @@ -37,7 +37,7 @@ Feature Test Macro Requirements for glibc (see
>  .nf
>  .BR fchmod ():
>      Since glibc 2.24:
> -        _POSIX_C_SOURCE >= 199309L
> +        _POSIX_C_SOURCE >= 1993\[aq]09L

Please keep all POSIX dates in a single separate patch
(unless there's another reason that I'm not seeing).

Cheers,

Alex

>  .\"        || (_XOPEN_SOURCE && _XOPEN_SOURCE_EXTENDED)
>      glibc 2.19 to glibc 2.23
>          _POSIX_C_SOURCE
> @@ -45,7 +45,7 @@ Feature Test Macro Requirements for glibc (see
>          _BSD_SOURCE || _POSIX_C_SOURCE
>      glibc 2.12 to glibc 2.16:
>          _BSD_SOURCE || _XOPEN_SOURCE >= 500
> -            || _POSIX_C_SOURCE >= 200809L
> +            || _POSIX_C_SOURCE >= 2008\[aq]09L
>      glibc 2.11 and earlier:
>          _BSD_SOURCE || _XOPEN_SOURCE >= 500
>  .\"        || (_XOPEN_SOURCE && _XOPEN_SOURCE_EXTENDED)
> @@ -54,7 +54,7 @@ Feature Test Macro Requirements for glibc (see
>  .BR fchmodat ():
>  .nf
>      Since glibc 2.10:
> -        _POSIX_C_SOURCE >= 200809L
> +        _POSIX_C_SOURCE >= 2008\[aq]09L
>      Before glibc 2.10:
>          _ATFILE_SOURCE
>  .fi
> @@ -82,11 +82,11 @@ The new file mode is specified in
>  which is a bit mask created by ORing together zero or
>  more of the following:
>  .TP 18
> -.BR S_ISUID "  (04000)"
> +.BR S_ISUID "  (04\[aq]000)"
>  set-user-ID (set process effective user ID on
>  .BR execve (2))
>  .TP
> -.BR S_ISGID "  (02000)"
> +.BR S_ISGID "  (02\[aq]000)"
>  set-group-ID (set process effective group ID on
>  .BR execve (2);
>  mandatory locking, as described in
> @@ -96,36 +96,36 @@ take a new file's group from parent directory, as described in
>  and
>  .BR mkdir (2))
>  .TP
> -.BR S_ISVTX "  (01000)"
> +.BR S_ISVTX "  (01\[aq]000)"
>  sticky bit (restricted deletion flag, as described in
>  .BR unlink (2))
>  .TP
> -.BR S_IRUSR "  (00400)"
> +.BR S_IRUSR "  (00\[aq]400)"
>  read by owner
>  .TP
> -.BR S_IWUSR "  (00200)"
> +.BR S_IWUSR "  (00\[aq]200)"
>  write by owner
>  .TP
> -.BR S_IXUSR "  (00100)"
> +.BR S_IXUSR "  (00\[aq]100)"
>  execute/search by owner ("search" applies for directories,
>  and means that entries within the directory can be accessed)
>  .TP
> -.BR S_IRGRP "  (00040)"
> +.BR S_IRGRP "  (00\[aq]040)"
>  read by group
>  .TP
> -.BR S_IWGRP "  (00020)"
> +.BR S_IWGRP "  (00\[aq]020)"
>  write by group
>  .TP
> -.BR S_IXGRP "  (00010)"
> +.BR S_IXGRP "  (00\[aq]010)"
>  execute/search by group
>  .TP
> -.BR S_IROTH "  (00004)"
> +.BR S_IROTH "  (00\[aq]004)"
>  read by others
>  .TP
> -.BR S_IWOTH "  (00002)"
> +.BR S_IWOTH "  (00\[aq]002)"
>  write by others
>  .TP
> -.BR S_IXOTH "  (00001)"
> +.BR S_IXOTH "  (00\[aq]001)"
>  execute/search by others
>  .PP
>  The effective UID of the calling process must match the owner of the file,

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]