From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, Florian Weimer <fweimer@redhat.com>,
Jakub Wilk <jwilk@jwilk.net>,
linux-man@vger.kernel.org, libc-alpha@sourceware.org
Subject: Re: [PATCH 00/39] man2: SYNOPSIS: Fix headers, use syscall(), and other fixes
Date: Tue, 11 May 2021 17:27:59 +1200 [thread overview]
Message-ID: <8124fcf3-8994-8a20-3a5b-ab0b848d39ad@gmail.com> (raw)
In-Reply-To: <20210510175546.28445-1-alx.manpages@gmail.com>
Hello Alex,
On 5/11/21 5:55 AM, Alejandro Colomar wrote:
>
> Hi Michael,
>
> This is the second set of SYNOPSIS fixes, mostly about fixing the includes,
> giving reasons why they are being included, and using syscall(SYS_...) when
> needed. Other minor fixes that I have noticed while doing this are also
> included in this set.
>
> After this set, about a 60% of man2 will be fixed.
>
> As with the previous patch set, please review thoroughly. I might have
> overlooked something. It looks good, but it's been a long time...
Things looked okay to me. I dropped the patch you asked me
to drop, and made a formatting after the getdents.2 patch
> I must notice that there are a few discrepancies (see the last mails there):
> <https://lore.kernel.org/linux-man/3d6feff0-f65b-f086-aa2a-be21ff90ccfe@gmail.com/T/#u>.
Yep. I real the discussion. I think I'm okay with your choice.
I've applied all of the patches.
Thanks,
Michael
> Alejandro Colomar (39):
> futex.2: Use syscall(SYS_...); for system calls without a wrapper
> getdents.2: Use syscall(SYS_...); for system calls without a wrapper
> ioctl_tty.2: Fix includes
> ioctl_userfaultfd.2: SYNOPSIS: Add <linux/userfaultfd.h>
> io_destroy.2: Use syscall(SYS_...); for system calls without a wrapper
> io_getevents.2: Use syscall(SYS_...); for system calls without a
> wrapper
> ioperm.2: Remove obvious comment
> ioprio_set.2: Use syscall(SYS_...); for system calls without a wrapper
> ipc.2: Use syscall(SYS_...); for system calls without a wrapper
> ipc.2: Add needed include
> kcmp.2: Use syscall(SYS_...); for system calls without a wrapper
> kcmp.2: tfix
> kexec_load.2: Use syscall(SYS_...); for system calls without a wrapper
> scripts/bash_aliases: man_lsfunc(): Extract syscall name from
> syscall(SYS_...)
> keyctl.2: Use syscall(SYS_...); for system calls without a glibc
> wrapper
> link.2: ffix
> llseek.2: Use syscall(SYS_...); for system calls without a wrapper
> lookup_dcookie.2: Use syscall(SYS_...); for system calls without a
> wrapper
> membarrier.2: Use syscall(SYS_...); for system calls without a wrapper
> mincore.2: Remove unused include
> mknod.2: Remove unused includes
> mmap2.2: Use syscall(SYS_...); for system calls without a wrapper
> modify_ldt.2: Use syscall(SYS_...); for system calls without a wrapper
> mq_getsetattr.2: Use syscall(SYS_...); for system calls without a
> wrapper
> alloc_hugepages.2, arch_prctl.2, capget.2, clone.2, delete_module.2,
> exit_group.2, get_robust_list.2, getunwind.2, init_module.2: Add
> note about the use of syscall(2)
> open.2: Remove unused <sys/stat.h>
> openat2.2: Use syscall(SYS_...); for system calls without a wrapper;
> fix includes too
> perf_event_open.2: Use syscall(SYS_...); for system calls without a
> wrapper
> pidfd_getfd.2: Use syscall(SYS_...); for system calls without a
> wrapper
> pidfd_open.2: Use syscall(SYS_...); for system calls without a wrapper
> pidfd_send_signal.2: Use syscall(SYS_...); for system calls without a
> wrapper. Fix includes too
> pipe.2: wfix
> pivot_root.2: Use syscall(SYS_...); for system calls without a wrapper
> poll.2: Remove <signal.h>
> process_madvise.2: Use syscall(SYS_...); for system calls without a
> wrapper. Fix includes too.
> quotactl.2: Better detail why <xfs/xqm.h> is included
> readdir.2: Use syscall(SYS_...); for system calls without a wrapper
> readlink.2: ffix
> reboot.2: Use syscall(SYS_...); for system calls without a wrapper
>
> man2/alloc_hugepages.2 | 5 +++++
> man2/arch_prctl.2 | 6 ++++++
> man2/capget.2 | 5 +++++
> man2/clone.2 | 6 ++++++
> man2/delete_module.2 | 6 ++++++
> man2/exit_group.2 | 6 ++++++
> man2/futex.2 | 21 +++++++++++----------
> man2/get_robust_list.2 | 5 +++++
> man2/getdents.2 | 20 +++++++++++++++-----
> man2/getunwind.2 | 6 ++++++
> man2/init_module.2 | 5 +++++
> man2/io_destroy.2 | 16 +++++++++-------
> man2/io_getevents.2 | 21 +++++++++++----------
> man2/ioctl_tty.2 | 6 +++---
> man2/ioctl_userfaultfd.2 | 1 +
> man2/ioperm.2 | 2 +-
> man2/ioprio_set.2 | 15 +++++++++------
> man2/ipc.2 | 19 ++++++++++++-------
> man2/kcmp.2 | 18 ++++++++++--------
> man2/kexec_load.2 | 24 +++++++++++++-----------
> man2/keyctl.2 | 17 +++++++----------
> man2/link.2 | 2 +-
> man2/llseek.2 | 13 +++++++------
> man2/lookup_dcookie.2 | 14 +++++++++-----
> man2/membarrier.2 | 16 ++++++++++------
> man2/mincore.2 | 1 -
> man2/mknod.2 | 2 --
> man2/mmap2.2 | 10 ++++++----
> man2/modify_ldt.2 | 15 ++++++++++-----
> man2/mq_getsetattr.2 | 15 ++++++---------
> man2/open.2 | 1 -
> man2/openat2.2 | 20 +++++++++++---------
> man2/perf_event_open.2 | 21 +++++++++++----------
> man2/pidfd_getfd.2 | 14 +++++++++-----
> man2/pidfd_open.2 | 13 ++++++++-----
> man2/pidfd_send_signal.2 | 16 ++++++++++------
> man2/pipe.2 | 4 ++--
> man2/pivot_root.2 | 14 +++++++++-----
> man2/poll.2 | 3 +--
> man2/process_madvise.2 | 20 ++++++++++++--------
> man2/quotactl.2 | 4 +++-
> man2/readdir.2 | 12 +++++++-----
> man2/readlink.2 | 2 +-
> man2/reboot.2 | 12 +++++++-----
> scripts/bash_aliases | 1 +
> 45 files changed, 293 insertions(+), 182 deletions(-)
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2021-05-11 5:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 17:55 [PATCH 00/39] man2: SYNOPSIS: Fix headers, use syscall(), and other fixes Alejandro Colomar
2021-05-10 17:55 ` [PATCH 01/39] futex.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 02/39] getdents.2: " Alejandro Colomar
2021-05-11 5:21 ` Michael Kerrisk (man-pages)
2021-05-10 17:55 ` [PATCH 03/39] ioctl_tty.2: Fix includes Alejandro Colomar
2021-05-10 17:55 ` [PATCH 04/39] ioctl_userfaultfd.2: SYNOPSIS: Add <linux/userfaultfd.h> Alejandro Colomar
2021-05-10 17:55 ` [PATCH 05/39] io_destroy.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 06/39] io_getevents.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 07/39] ioperm.2: Remove obvious comment Alejandro Colomar
2021-05-10 17:55 ` [PATCH 08/39] ioprio_set.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 09/39] ipc.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 10/39] ipc.2: Add needed include Alejandro Colomar
2021-05-10 17:55 ` [PATCH 11/39] kcmp.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 12/39] kcmp.2: tfix Alejandro Colomar
2021-05-10 17:55 ` [PATCH 13/39] kexec_load.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 14/39] scripts/bash_aliases: man_lsfunc(): Extract syscall name from syscall(SYS_...) Alejandro Colomar
2021-05-10 17:55 ` [PATCH 15/39] keyctl.2: Use syscall(SYS_...); for system calls without a glibc wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 16/39] link.2: ffix Alejandro Colomar
2021-05-10 17:55 ` [PATCH 17/39] llseek.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 18/39] lookup_dcookie.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 19/39] membarrier.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 20/39] mincore.2: Remove unused include Alejandro Colomar
2021-05-10 17:55 ` [PATCH 21/39] mknod.2: Remove unused includes Alejandro Colomar
2021-05-10 17:55 ` [PATCH 22/39] mmap2.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 23/39] modify_ldt.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 24/39] mq_getsetattr.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 25/39] alloc_hugepages.2, arch_prctl.2, capget.2, clone.2, delete_module.2, exit_group.2, get_robust_list.2, getunwind.2, init_module.2: Add note about the use of syscall(2) Alejandro Colomar
2021-05-10 17:55 ` [PATCH 26/39] open.2: Remove unused <sys/stat.h> Alejandro Colomar
2021-05-10 18:02 ` Alejandro Colomar (man-pages)
2021-05-11 5:15 ` Michael Kerrisk (man-pages)
2021-05-10 17:55 ` [PATCH 27/39] openat2.2: Use syscall(SYS_...); for system calls without a wrapper; fix includes too Alejandro Colomar
2021-05-10 17:55 ` [PATCH 28/39] perf_event_open.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 29/39] pidfd_getfd.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 30/39] pidfd_open.2: " Alejandro Colomar
2021-05-10 17:55 ` [PATCH 31/39] pidfd_send_signal.2: Use syscall(SYS_...); for system calls without a wrapper. Fix includes too Alejandro Colomar
2021-05-10 17:55 ` [PATCH 32/39] pipe.2: wfix Alejandro Colomar
2021-05-10 17:55 ` [PATCH 33/39] pivot_root.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 34/39] poll.2: Remove <signal.h> Alejandro Colomar
2021-05-10 17:55 ` [PATCH 35/39] process_madvise.2: Use syscall(SYS_...); for system calls without a wrapper. Fix includes too Alejandro Colomar
2021-05-10 17:55 ` [PATCH 36/39] quotactl.2: Better detail why <xfs/xqm.h> is included Alejandro Colomar
2021-05-10 17:55 ` [PATCH 37/39] readdir.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 17:55 ` [PATCH 38/39] readlink.2: ffix Alejandro Colomar
2021-05-10 17:55 ` [PATCH 39/39] reboot.2: Use syscall(SYS_...); for system calls without a wrapper Alejandro Colomar
2021-05-10 18:02 ` Alejandro Colomar (man-pages)
2021-05-11 5:19 ` Michael Kerrisk (man-pages)
2021-05-11 5:27 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8124fcf3-8994-8a20-3a5b-ab0b848d39ad@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=fweimer@redhat.com \
--cc=jwilk@jwilk.net \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox