public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, Shawn Landden <shawn@git.icu>,
	linux-man@vger.kernel.org, Nora Platiel <nplatiel@gmx.us>
Subject: Re: [PATCH 32/32] execve.2: Fix absolute/relative pathname
Date: Sun, 8 Aug 2021 04:02:56 +0200	[thread overview]
Message-ID: <861f5cd9-cb06-23a7-3bcc-166e9b7e074a@gmail.com> (raw)
In-Reply-To: <20210728202008.3158-33-alx.manpages@gmail.com>

Hello Alex, Shawn, and Nora,

@Nora, thanks for the bug report.

On 7/28/21 10:20 PM, Alejandro Colomar wrote:
> From: Shawn Landden <shawn@git.icu>
> 
> The absolute pathname is available in the Linux-specific
> auxiliary-vector feature.

@Shawn
But this isn't true, as far as I can see. See the following:

[[
$ cat auxv.c 
#include <link.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>

extern char **environ;

int
main(int argc, char *argv[])
{
    char **p;

    /* Walk through the array of pointers in environ */

    for (p = environ; *p != NULL; p++)
        continue;

    /* The auxiliary vector sits just above environ */

    p++;        /* Step past NULL pointer at end of 'environ' */

    printf("auxvec                        %12p\n", (void *) p);

    ElfW(auxv_t) *auxv = (ElfW(auxv_t) *) p;

    while (auxv->a_type != 0) {

        switch (auxv->a_type) {
        case AT_PLATFORM:
                        /* String identifying hardware platform */
            printf("AT_PLATFORM:      0x%llx (string: %s)\n",
                    (long long) auxv->a_un.a_val, (char *) auxv->a_un.a_val);
            break;
        case AT_SECURE: /* Was secure-execution mode triggered for dynamic
                           linker? See ld.so(8). */
            printf("AT_SECURE:        %lld\n", (long long) auxv->a_un.a_val);
            break;
        case AT_EXECFN: /* Pathname used to execute program */
            printf("AT_EXECFN:        0x%llx (string: %s)\n",
                    (long long) auxv->a_un.a_val, (char *) auxv->a_un.a_val);
            break;
        default:
            /* We ignore other types of entries in auxiliary vector */
            break;
        }

        auxv++;
    }

    exit(EXIT_SUCCESS);
}
$ ./auxv
auxvec                        0x7ffd5c6eb708
AT_SECURE:        0
AT_EXECFN:        0x7ffd5c6ecff1 (string: ./auxv)
AT_PLATFORM:      0x7ffd5c6eb859 (string: x86_64)
]]

> 
> Reported-by: Nora Platiel <nplatiel@gmx.us>
> Signed-off-by: Shawn Landden <shawn@git.icu>
> Reviewed-by: Nora Platiel <nplatiel@gmx.us>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
>  man2/execve.2 | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/execve.2 b/man2/execve.2
> index c18ca5412..7fe12ab42 100644
> --- a/man2/execve.2
> +++ b/man2/execve.2
> @@ -346,7 +346,9 @@ will be invoked with the following arguments:
>  .PP
>  where
>  .I pathname
> -is the absolute pathname of the file specified as the first argument of
> +is the absolute pathname of the file specified (may be relative to
> +.BR getcwd (3)
> +of the caller) as the first argument of
>  .BR execve (),

I find the "(may be relative...)" piece confusing.

It's simpler just to s/absolute pathname/pathname/, and that's the
change I made.

>  and
>  .I arg...
> @@ -356,6 +358,11 @@ argument of
>  .BR execve (),
>  starting at
>  .IR argv[1] .
> +The absolute pathname of the script is also available
> +in the same auxiliary vector the environment and argument variables are in, as
> +.BR AT_EXECFN .
> +See
> +.BR getauxval (3).
>  Note that there is no way to get the
>  .IR argv[0]
>  that was passed to the

I applied the patch below.

Cheers,

Michael

diff --git a/man2/execve.2 b/man2/execve.2
index 435a6b363..4eaf1967e 100644
--- a/man2/execve.2
+++ b/man2/execve.2
@@ -346,7 +346,7 @@ will be invoked with the following arguments:
 .PP
 where
 .I pathname
-is the absolute pathname of the file specified as the first argument of
+is the pathname of the file specified as the first argument of
 .BR execve (),
 and
 .I arg...


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  reply	other threads:[~2021-08-08  2:03 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 20:19 [PATCH 00/32] Patches from others Alejandro Colomar
2021-07-28 20:19 ` [PATCH 01/32] readv2: Note preadv2(..., RWF_NOWAIT) bug in BUGS section Alejandro Colomar
2021-08-08  2:29   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 02/32] readv.2: Minor tweaks to Will's patch Alejandro Colomar
2021-08-08  2:30   ` Michael Kerrisk (man-pages)
2021-08-08  2:42     ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 03/32] vdso.7: Remove outdated limitation for powerpc Alejandro Colomar
2021-08-08  0:17   ` Michael Kerrisk (man-pages)
2021-08-08  0:21     ` Alejandro Colomar (man-pages)
2021-07-28 20:19 ` [PATCH 04/32] vdso.7: Add y2038 compliant gettime for ppc/32 Alejandro Colomar
2021-08-08  0:48   ` Michael Kerrisk (man-pages)
2021-08-08  1:01     ` Alejandro Colomar (man-pages)
2021-08-08  2:25       ` Michael Kerrisk (man-pages)
2021-08-08  2:22   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 05/32] posixoptions.7: Fix legacy functions list (s/getcwd/getwd/) Alejandro Colomar
2021-08-08  0:55   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 06/32] man2/fallocate.2: tfix documentation of shared blocks Alejandro Colomar
2021-08-08  0:54   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 07/32] printf.3: wfix Alejandro Colomar
2021-08-07 21:34   ` Michael Kerrisk (man-pages)
2021-08-07 22:20     ` Alejandro Colomar (man-pages)
2021-08-07 22:32       ` Alejandro Colomar (man-pages)
2021-08-07 23:10         ` Michael Kerrisk (man-pages)
2021-08-11 20:55           ` Sergey Petrakov
2021-08-11 22:33             ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 08/32] Various pages: Consistently use '*argv[]' Alejandro Colomar
2021-08-07 21:35   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 09/32] path_resolution.7: tfix Alejandro Colomar
2021-08-07 21:37   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 10/32] futex.2: Document FUTEX_LOCK_PI2 Alejandro Colomar
2021-07-29 10:18   ` Alejandro Colomar (man-pages)
2021-08-07 21:38     ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 11/32] futex.2: Minor tweaks to Kurt's patch Alejandro Colomar
2021-07-29 10:24   ` Alejandro Colomar (man-pages)
2021-08-07 21:38     ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 12/32] capabilities.7: tfix Alejandro Colomar
2021-08-07 21:39   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 13/32] user_namespaces.7: fix a ref Alejandro Colomar
2021-08-07 21:40   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 14/32] capabilities.7, user_namespaces.7: describe CAP_SETFCAP Alejandro Colomar
2021-08-08  2:54   ` Michael Kerrisk (man-pages)
2021-08-08  9:09   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 15/32] capabilities.7: Minor tweaks to Kir's patch Alejandro Colomar
2021-07-29 11:16   ` Alejandro Colomar (man-pages)
2021-08-08  3:03   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 16/32] seccomp_unotify.2: Add doc for SECCOMP_ADDFD_FLAG_SEND Alejandro Colomar
2021-08-08  1:01   ` Michael Kerrisk (man-pages)
2021-08-09  9:42     ` Rodrigo Campos
2021-07-28 20:19 ` [PATCH 17/32] seccomp_unotify.2: Minor tweaks to Rodrigo's patch Alejandro Colomar
2021-07-29 11:15   ` Alejandro Colomar (man-pages)
2021-08-08  1:13   ` Michael Kerrisk (man-pages)
2021-08-08  1:22     ` Alejandro Colomar (man-pages)
2021-07-28 20:19 ` [PATCH 18/32] recv.2: tfix Alejandro Colomar
2021-08-07 21:43   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 19/32] ascii.7: add vertical rule to separate the two columns Alejandro Colomar
2021-08-07 22:46   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 20/32] wait.2: Add ESRCH for when pid == INT_MIN Alejandro Colomar
2021-08-07 23:05   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 21/32] seccomp_unotify.2: tfix Alejandro Colomar
2021-08-08  1:13   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 22/32] proc.5: tfix Alejandro Colomar
2021-08-07 22:55   ` Michael Kerrisk (man-pages)
2021-07-28 20:19 ` [PATCH 23/32] scripts/bash_aliases: tfix Alejandro Colomar
2021-08-07 22:47   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 24/32] namespaces.7: fix confusion caused by text reorganization Alejandro Colomar
2021-08-07 23:48   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 25/32] pipe.7: also mention writev(2) in atomicity sexion Alejandro Colomar
2021-08-08  9:30   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 26/32] tkill.2: tfix Alejandro Colomar
2021-08-07 22:48   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 27/32] strstr.3: Add special case for empty needle Alejandro Colomar
2021-08-07 23:53   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 28/32] sigaction.2: Document SA_EXPOSE_TAGBITS and the flag support detection protocol Alejandro Colomar
2021-08-08 21:32   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 29/32] sigaction.2: Apply minor tweaks to Peter's patch Alejandro Colomar
2021-07-29 11:14   ` Alejandro Colomar (man-pages)
2021-08-08 21:32   ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 30/32] strlen.3, wcslen.3: Add recommendations for safer variants Alejandro Colomar
2021-08-07 23:45   ` Michael Kerrisk (man-pages)
2021-08-08  0:04     ` Alejandro Colomar (man-pages)
2021-08-08  0:16     ` Alejandro Colomar (man-pages)
2021-08-08  1:20       ` Michael Kerrisk (man-pages)
2021-08-08  1:24         ` Alejandro Colomar (man-pages)
2021-08-08  2:18           ` Michael Kerrisk (man-pages)
2021-08-08 19:44       ` Jonny Grant
2021-07-28 20:20 ` [PATCH 31/32] time.2: wfix regarding year-2038 Alejandro Colomar
2021-07-29 10:45   ` G. Branden Robinson
2021-07-30  1:25     ` Viet Than
2021-08-07 23:59       ` Michael Kerrisk (man-pages)
2021-07-28 20:20 ` [PATCH 32/32] execve.2: Fix absolute/relative pathname Alejandro Colomar
2021-08-08  2:02   ` Michael Kerrisk (man-pages) [this message]
2021-08-08 21:34 ` [PATCH 00/32] Patches from others Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861f5cd9-cb06-23a7-3bcc-166e9b7e074a@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=nplatiel@gmx.us \
    --cc=shawn@git.icu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox