[patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Vladislav Ivanishin]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-recv.2-Mention-SOCK_SEQPACKET-in-MSG_TRUNC-descripti.patch --]
[-- Type: text/x-patch, Size: 917 bytes --]

unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles
MSG_TRUNC. This has been the case since the support for this flag was
implemented in the latter; the sequential-packet socket type seems to
have been left out from the description by an oversight.

Signed-off-by: Vladislav Ivanishin <vlad@ispras.ru>
---
 man2/recv.2 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man2/recv.2 b/man2/recv.2
index d492976c4..c5f1a9d70 100644
--- a/man2/recv.2
+++ b/man2/recv.2
@@ -226,7 +226,8 @@ subsequent receive call will return the same data.
 For raw
 .RB ( AF_PACKET ),
 Internet datagram (since Linux 2.4.27/2.6.8),
-netlink (since Linux 2.6.22), and UNIX datagram
+netlink (since Linux 2.6.22),
+and UNIX datagram as well as sequenced-packet
 .\" commit 9f6f9af7694ede6314bed281eec74d588ba9474f
 (since Linux 3.4) sockets:
 return the real length of the packet or datagram,
-- 
2.37.3

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 1245 bytes --]

Hi Vladislav,

On 11/27/22 11:38, Vladislav Ivanishin wrote:
> unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles
> MSG_TRUNC. This has been the case since the support for this flag was
> implemented in the latter; the sequential-packet socket type seems to
> have been left out from the description by an oversight.
> 
> Signed-off-by: Vladislav Ivanishin<vlad@ispras.ru>

Could you please point to the relevant kernel commits, or quote the relevant 
lines of code, in the commit message?

Thanks,

Alex

> ---
>   man2/recv.2 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/recv.2 b/man2/recv.2
> index d492976c4..c5f1a9d70 100644
> --- a/man2/recv.2
> +++ b/man2/recv.2
> @@ -226,7 +226,8 @@ subsequent receive call will return the same data.
>   For raw
>   .RB ( AF_PACKET ),
>   Internet datagram (since Linux 2.4.27/2.6.8),
> -netlink (since Linux 2.6.22), and UNIX datagram
> +netlink (since Linux 2.6.22),
> +and UNIX datagram as well as sequenced-packet
>   .\" commit 9f6f9af7694ede6314bed281eec74d588ba9474f
>   (since Linux 3.4) sockets:
>   return the real length of the packet or datagram,
> -- 2.37.3

-- 
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Vladislav Ivanishin]

unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles
MSG_TRUNC. This has been the case since the handling was added in
9f6f9af7694ede6314bed281eec74d588ba9474f; see net/unix/af_unix.c:

static int unix_seqpacket_recvmsg([...])
{
        [...]
	return unix_dgram_recvmsg(iocb, sock, msg, size, flags);
}

The sequential-packet socket type seems to have been left out from the
description by an oversight.

Signed-off-by: Vladislav Ivanishin <vlad@ispras.ru>
---

Hi Alex,

On Sun, Dec 11 2022, Alejandro Colomar <alx.manpages@gmail.com> wrote:
> Hi Vladislav,
>
> On 11/27/22 11:38, Vladislav Ivanishin wrote:
>> unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles
>> MSG_TRUNC. This has been the case since the support for this flag was
>> implemented in the latter; the sequential-packet socket type seems to
>> have been left out from the description by an oversight.
>> Signed-off-by: Vladislav Ivanishin<vlad@ispras.ru>
>
> Could you please point to the relevant kernel commits, or quote the relevant
> lines of code, in the commit message?
>
> Thanks,
>
> Alex
    
Sure, here's an updated version.

Vlad

 man2/recv.2 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man2/recv.2 b/man2/recv.2
index 5298a2745..81cd1957c 100644
--- a/man2/recv.2
+++ b/man2/recv.2
@@ -226,7 +226,8 @@ subsequent receive call will return the same data.
 For raw
 .RB ( AF_PACKET ),
 Internet datagram (since Linux 2.4.27/2.6.8),
-netlink (since Linux 2.6.22), and UNIX datagram
+netlink (since Linux 2.6.22),
+and UNIX datagram as well as sequenced-packet
 .\" commit 9f6f9af7694ede6314bed281eec74d588ba9474f
 (since Linux 3.4) sockets:
 return the real length of the packet or datagram,
-- 
2.39.1

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 2219 bytes --]

Hi Vladislav!

On 2/12/23 14:38, Vladislav Ivanishin wrote:
> 
> unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles
> MSG_TRUNC. This has been the case since the handling was added in
> 9f6f9af7694ede6314bed281eec74d588ba9474f; see net/unix/af_unix.c:
> 
> static int unix_seqpacket_recvmsg([...])
> {
>         [...]
> 	return unix_dgram_recvmsg(iocb, sock, msg, size, flags);
> }
> 
> The sequential-packet socket type seems to have been left out from the
> description by an oversight.
> 
> Signed-off-by: Vladislav Ivanishin <vlad@ispras.ru>
> ---
> 
> Hi Alex,
> 
> On Sun, Dec 11 2022, Alejandro Colomar <alx.manpages@gmail.com> wrote:
>> Hi Vladislav,
>>
>> On 11/27/22 11:38, Vladislav Ivanishin wrote:
>>> unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles
>>> MSG_TRUNC. This has been the case since the support for this flag was
>>> implemented in the latter; the sequential-packet socket type seems to
>>> have been left out from the description by an oversight.
>>> Signed-off-by: Vladislav Ivanishin<vlad@ispras.ru>
>>
>> Could you please point to the relevant kernel commits, or quote the relevant
>> lines of code, in the commit message?
>>
>> Thanks,
>>
>> Alex
>     
> Sure, here's an updated version.

Thanks!  I CCd those involved in the referred commit.  I'll give them a week or so to have a look.  Could you please ping me again in a week or so?

Cheers,

Alex
> 
> Vlad
> 
>  man2/recv.2 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/recv.2 b/man2/recv.2
> index 5298a2745..81cd1957c 100644
> --- a/man2/recv.2
> +++ b/man2/recv.2
> @@ -226,7 +226,8 @@ subsequent receive call will return the same data.
>  For raw
>  .RB ( AF_PACKET ),
>  Internet datagram (since Linux 2.4.27/2.6.8),
> -netlink (since Linux 2.6.22), and UNIX datagram
> +netlink (since Linux 2.6.22),
> +and UNIX datagram as well as sequenced-packet
>  .\" commit 9f6f9af7694ede6314bed281eec74d588ba9474f
>  (since Linux 3.4) sockets:
>  return the real length of the packet or datagram,

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Vladislav Ivanishin]

On Sun, Feb 12 2023, Alejandro Colomar <alx.manpages@gmail.com> wrote:
> Thanks!  I CCd those involved in the referred commit.  I'll give them
> a week or so to have a look.

Great, thank you!

> Could you please ping me again in a week or so?

No problem, will do.

Vlad

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Vladislav Ivanishin]

Hi Alex; ping!

On Mon, Feb 13 2023, Vladislav Ivanishin <vlad@ispras.ru> wrote:
> On Sun, Feb 12 2023, Alejandro Colomar <alx.manpages@gmail.com> wrote:
>> Thanks!  I CCd those involved in the referred commit.  I'll give them
>> a week or so to have a look.
>
> Great, thank you!
>
>> Could you please ping me again in a week or so?
>
> No problem, will do.

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Vladislav Ivanishin]

Ping (there haven't been any objections to the current version of the
patch at https://lore.kernel.org/linux-man/87cz6fqa0z.fsf@ispras.ru/).

On Mon, Feb 20 2023, Vladislav Ivanishin <vlad@ispras.ru> wrote:
> Hi Alex; ping!
>
> On Mon, Feb 13 2023, Vladislav Ivanishin <vlad@ispras.ru> wrote:
>> On Sun, Feb 12 2023, Alejandro Colomar <alx.manpages@gmail.com> wrote:
>>> Thanks!  I CCd those involved in the referred commit.  I'll give them
>>> a week or so to have a look.
>>
>> Great, thank you!
>>
>>> Could you please ping me again in a week or so?
>>
>> No problem, will do.

Re: [patch] recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]

Hi Vlad,

On 3/5/23 19:06, Vladislav Ivanishin wrote:
> Ping (there haven't been any objections to the current version of the
> patch at https://lore.kernel.org/linux-man/87cz6fqa0z.fsf@ispras.ru/).
> 
> On Mon, Feb 20 2023, Vladislav Ivanishin <vlad@ispras.ru> wrote:
>> Hi Alex; ping!
Thanks for both pings, and sorry for the delay :)

Patch applied.

Cheers,

Alex

>>
>> On Mon, Feb 13 2023, Vladislav Ivanishin <vlad@ispras.ru> wrote:
>>> On Sun, Feb 12 2023, Alejandro Colomar <alx.manpages@gmail.com> wrote:
>>>> Thanks!  I CCd those involved in the referred commit.  I'll give them
>>>> a week or so to have a look.
>>>
>>> Great, thank you!
>>>
>>>> Could you please ping me again in a week or so?
>>>
>>> No problem, will do.
-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]