Re: [PATCH v5] prctl.2: Document Syscall User Dispatch

[Gabriel Krisman Bertazi <krisman@collabora.com>]

"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:

> On Mon, 28 Dec 2020 at 21:41, Alejandro Colomar (man-pages)
> <alx.manpages@gmail.com> wrote:
>>
>>
>>
>> On 12/28/20 9:06 PM, Michael Kerrisk (man-pages) wrote:
>> > Hi Alex,
>> >
>> > On Mon, 28 Dec 2020 at 19:24, Alejandro Colomar (man-pages)
>> > <alx.manpages@gmail.com> wrote:
>> >>
>> >> Hi Michael & Gabriel,
>> >>
>> >> I disagree on a comment; see below.
>> >>
>> >> On 12/24/20 10:18 AM, Michael Kerrisk (man-pages) wrote:
>> >>> Hello Gabriel,
>> >>>
>> >>> Thanks for the revisions!
>> >>>
>> >> [...]
>> >>>> +.IP
>> >>>> +When
>> >>>> +.I arg2
>> >>>> +is set to
>> >>>> +.BR PR_SYS_DISPATCH_ON ,
>> >>>> +.I arg3
>> >>>> +and
>> >>>> +.I arg4
>> >>>> +respectively identify the
>> >>>> +.I offset
>> >>>> +and
>> >>>> +.I length
>> >>>> +of a single contiguous memory region in the process map
>> >>>> +from where system calls are always allowed to be executed,
>> >>>> +regardless of the switch variable
>> >>>> +(Typically, this area would include the area of memory
>> >>>> +containing the C library).
>> >>>
>> >>> s/)./.)/
>> >>
>> >> That point is ending the full sentence starting at 'When',
>> >
>> > I see it the other. The piece in parentheses is a free-standing idea
>> > that should be (parenthetical) sentence on its own.
>> >
>> > But, if that was not the case, your points below would hold.
>>
>> Hi Michael,
>>
>> I see; but there still isn't any separator between '... switch
>> variable', and 'arg5 points to ...'.
>>
>> Would you then do?:
>>
>> [
>> +regardless of the switch variable_._
>> ]
>>
>> Or what?
>
> Oh yes. I missed that. That period also needs to be added!
>

Which one?

> +regardless of the switch variable_._

or

> I see; but there still isn't any separator between '... switch
> variable', and 'arg5 points to ...'.

which would be .). 

-- 
Gabriel Krisman Bertazi