From: Florian Weimer <fw@deneb.enyo.de>
To: Alejandro Colomar <alx@kernel.org>
Cc: Sergei Trofimovich <slyich@gmail.com>,
linux-man@vger.kernel.org, Boris Pigin <boris.pigin@gmail.com>
Subject: Re: [PATCH] mk: don't escape '#' for `grep`
Date: Thu, 27 Feb 2025 15:43:29 +0100 [thread overview]
Message-ID: <878qpr78j2.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <ha62i7u3tqzovwf62evd27erfwx57anmist4odhldi6npzr4ok@esbl7yn54egh> (Alejandro Colomar's message of "Thu, 27 Feb 2025 13:28:12 +0100")
* Alejandro Colomar:
> Could you please try to find out the cause of the actual problem? Maybe
> there's a fix that doesn't involve reverting that patch. Or maybe
> there's a bug in some tool, and we can report it.
NEWS in GNU make explains this:
* WARNING: Backward-incompatibility!
Number signs (#) appearing inside a macro reference or function invocation
no longer introduce comments and should not be escaped with backslashes:
thus a call such as:
foo := $(shell echo '#')
is legal. Previously the number sign needed to be escaped, for example:
foo := $(shell echo '\#')
Now this latter will resolve to "\#". If you want to write makefiles
portable to both versions, assign the number sign to a variable:
H := \#
foo := $(shell echo '$H')
This was claimed to be fixed in 3.81, but wasn't, for some reason.
To detect this change search for 'nocomment' in the .FEATURES variable.
Applying the $H suggestion seems harmless enough, although this make
change seems to be fairly problematic in general.
next prev parent reply other threads:[~2025-02-27 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 9:21 [PATCH] mk: don't escape '#' for `grep` Sergei Trofimovich
2025-02-27 10:23 ` Alejandro Colomar
2025-02-27 11:23 ` Sergei Trofimovich
2025-02-27 12:28 ` Alejandro Colomar
2025-02-27 14:43 ` Florian Weimer [this message]
2025-02-27 15:20 ` Alejandro Colomar
2025-02-27 16:28 ` Jakub Wilk
2025-02-27 19:00 ` Alejandro Colomar
2025-02-27 19:30 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qpr78j2.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=alx@kernel.org \
--cc=boris.pigin@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=slyich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox