Re: groff build problem involving "ckd_mul" and "ckd_add"

[Collin Funk <collin.funk1@gmail.com>]

Alejandro Colomar <alx@kernel.org> writes:

>> It builds for me and others, like Deri and Grisha Levit.
>> 
>> https://lists.gnu.org/archive/html/groff/2025-10/msg00009.html
>> 
>> Have you "bootstrapped" lately?  That's necessary for Git users when we
>> bump the version of gnulib we include, which we probably did after
>> either 1.23.0.2695-49927 or 1.23.0.1254-19a18, and maybe both.  One
>> thing I do recall is bumping gnulib to get at the checked arithmetic
>> functions--precisely the ones you see above.
>
> Yes, I bootstrapped today.  I also ran 'git submodule update' prior to
> that.
>
>> 
>> Also, FYI:
>> 
>> $ git describe origin/master
>> 1.23.0-4017-g3ea378d35
>
> I can reproduce both on my server (Debian) and on my desktop (Devuan).
> I'm using Sid, so that may have something to do (maybe I have a more
> recent compiler that errors where yours doesn't?).

This was discussed and fixed in Gnulib a few months ago [1]. I assume
you are using g++ 15 and the others are not.

Here are the relevant commits:

    $ git branch --contains=7ee6e40b6730c87e5c1323bb5c2564bcb6eff9e4
    * master
      stable-202507
    $ git branch --contains=e331531a771443edae4135e6bcd016282cf1a3aa
    * master
      stable-202507

But groff is using a branch that does not contain them:

    commit e3ff929ddea95e0fc9fe7ea3541d28665de42370
    Author:     G. Branden Robinson <g.branden.robinson@gmail.com>
    AuthorDate: Fri Mar 28 03:10:49 2025 -0500
    Commit:     G. Branden Robinson <g.branden.robinson@gmail.com>
    CommitDate: Sat Mar 29 22:27:32 2025 -0500
    
        gnulib: Update stable/2025-01 branch.
        
        ...to commit 3fbc2c7bb3, 3 March.

Using the following command I can make ./bootstrap use the master branch
from my local checkout to copy files:

    $ env GNULIB_SRCDIR=$HOME/.local/src/gnulib ./bootstrap

Allows me to build groff fine with g++ 15.

Collin

[1] https://lists.gnu.org/archive/html/bug-gnulib/2025-05/msg00207.html