From: Sam James <sam@gentoo.org>
To: Jonathan Wakely via Gcc <gcc@gcc.gnu.org>
Cc: Xi Ruoyao <xry111@xry111.site>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
Alejandro Colomar <alx@kernel.org>,
Martin Uecker <muecker@gwdg.de>,
Jakub Jelinek <jakub@redhat.com>,
libc-alpha@sourceware.org, Paul Eggert <eggert@cs.ucla.edu>,
linux-man@vger.kernel.org
Subject: Re: [PATCH v1] Remove 'restrict' from 'nptr' in strtol(3)-like functions
Date: Fri, 05 Jul 2024 17:32:16 +0100 [thread overview]
Message-ID: <87jzhz241b.fsf@gentoo.org> (raw)
In-Reply-To: <CAH6eHdT0NWVEAZ8ZwCc0WCR6RE5-pGJCGKatWyAb9chDZhWjGw@mail.gmail.com> (Jonathan Wakely via Gcc's message of "Fri, 5 Jul 2024 17:24:41 +0100")
Jonathan Wakely via Gcc <gcc@gcc.gnu.org> writes:
> On Fri, 5 Jul 2024 at 17:02, Xi Ruoyao via Gcc <gcc@gcc.gnu.org> wrote:
>>
>> On Fri, 2024-07-05 at 17:53 +0200, Alejandro Colomar wrote:
>> > At least, I hope there's consensus that while current GCC doesn't warn
>> > about this, ideally it should, which means it should warn for valid uses
>> > of strtol(3), which means strtol(3) should be fixed, in all of ISO,
>> > POSIX, and glibc.
>>
>> It **shouldn't**. strtol will only violate restrict if it's wrongly
>> implemented, or something dumb is done like "strtol((const char*) &p,
>> &p, 0)".
>>
>> See my previous reply.
>
> Right, is there a valid use of strtol where a warning would be justified?
>
> Showing that you can contrive a case where a const char* restrict and
> char** restrict can alias doesn't mean there's a problem with strtol.
I still don't understand why it'd be appropriate for GCC and glibc to
override this without it even being *brought to* the committee, either.
next prev parent reply other threads:[~2024-07-05 16:32 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240705130249.14116-2-alx@kernel.org>
[not found] ` <38982a470643f766747b0ca06b27ca859a87b101.camel@xry111.site>
2024-07-05 14:37 ` [PATCH v1] Remove 'restrict' from 'nptr' in strtol(3)-like functions Alejandro Colomar
2024-07-05 15:02 ` Martin Uecker
2024-07-05 15:23 ` Alejandro Colomar
2024-07-05 15:34 ` Martin Uecker
2024-07-05 15:53 ` Alejandro Colomar
2024-07-05 16:01 ` Xi Ruoyao
2024-07-05 16:17 ` Xi Ruoyao
2024-07-05 16:24 ` Jonathan Wakely
2024-07-05 16:30 ` Martin Uecker
2024-07-05 19:28 ` Alejandro Colomar
2024-07-05 19:38 ` Jonathan Wakely
2024-07-05 19:47 ` Alejandro Colomar
2024-07-05 19:52 ` Jonathan Wakely
2024-07-05 20:11 ` Alejandro Colomar
2024-07-05 20:15 ` Emanuele Torre
2024-07-05 20:31 ` Ben Boeckel
2024-07-05 20:25 ` Martin Uecker
2024-07-05 20:28 ` Jonathan Wakely
2024-07-05 20:41 ` Alejandro Colomar
2024-07-05 20:55 ` Alejandro Colomar
2024-07-05 21:39 ` Jonathan Wakely
2024-07-05 22:02 ` Alejandro Colomar
2024-07-05 22:04 ` Alejandro Colomar
2024-07-06 2:24 ` Xi Ruoyao
2024-07-06 2:39 ` Xi Ruoyao
2024-07-06 5:51 ` [[gnu::null_terminated_string_arg(1)]] on strtol(1) (was: [PATCH v1] Remove 'restrict' from 'nptr' in strtol(3)-like) functions Alejandro Colomar
2024-07-06 6:10 ` [PATCH v1] Remove 'restrict' from 'nptr' in strtol(3)-like functions Alejandro Colomar
2024-07-06 6:11 ` Alejandro Colomar
2024-07-05 16:32 ` Sam James [this message]
2024-07-05 16:02 ` Martin Uecker
2024-07-05 16:11 ` Jonathan Wakely
2024-07-05 16:21 ` Richard Earnshaw (lists)
2024-07-05 15:54 ` LIU Hao
2024-07-05 15:55 ` Xi Ruoyao
2024-07-05 16:32 ` Alejandro Colomar
2024-07-05 17:32 ` Alejandro Colomar
2024-07-05 19:41 ` [WG14] Request for document number; strtol restrictness Alejandro Colomar
2024-07-07 15:46 ` Daniel Plakosh
2024-07-09 19:00 ` Alejandro Colomar
2024-07-09 20:04 ` Daniel Plakosh
2024-07-07 1:58 ` WG14 paper for removing restrict from nptr in strtol(3) Alejandro Colomar
2024-07-07 7:15 ` Martin Uecker
2024-07-07 11:07 ` Alejandro Colomar
2024-07-07 12:21 ` Martin Uecker
2024-07-07 13:10 ` Alejandro Colomar
2024-07-07 10:42 ` Paul Eggert
2024-07-07 12:42 ` Alejandro Colomar
2024-07-07 17:30 ` Paul Eggert
2024-07-07 22:52 ` Alejandro Colomar
2024-07-09 12:09 ` Paul Eggert
2024-07-09 17:36 ` Alejandro Colomar
2024-07-08 14:30 ` David Malcolm
2024-07-08 15:01 ` Alejandro Colomar
2024-07-08 16:05 ` Martin Uecker
2024-07-08 20:17 ` Alejandro Colomar
2024-07-09 5:58 ` Martin Uecker
2024-07-09 9:26 ` Alejandro Colomar
2024-07-08 22:48 ` David Malcolm
2024-07-09 9:07 ` Alejandro Colomar
2024-07-09 9:18 ` Jakub Jelinek
2024-07-09 10:28 ` Alejandro Colomar
2024-07-09 11:28 ` Alejandro Colomar
2024-07-09 22:42 ` n3294 - The restrict function attribute as a replacement of the restrict qualifier Alejandro Colomar
2024-07-26 16:24 ` Joseph Myers
2024-07-26 16:35 ` G. Branden Robinson
2024-07-26 19:53 ` Alejandro Colomar
2024-07-26 18:50 ` Paul Eggert
2024-07-26 20:11 ` Alejandro Colomar
2024-07-26 20:30 ` Joseph Myers
2024-07-26 21:14 ` Alejandro Colomar
2024-07-26 21:22 ` Joseph Myers
2024-07-26 21:49 ` Alejandro Colomar
2024-07-26 22:03 ` Martin Uecker
2024-07-26 22:26 ` Alejandro Colomar
2024-07-26 22:59 ` Martin Uecker
2024-07-27 8:44 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzhz241b.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=alx@kernel.org \
--cc=eggert@cs.ucla.edu \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely.gcc@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
--cc=muecker@gwdg.de \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox