public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH v2] circleq.3, list.3, slist.3, stailq.3, tailq.3: Improve readability, especially in SYNOPSIS
Date: Wed, 6 Jan 2021 12:12:49 +0100	[thread overview]
Message-ID: <894de45b-b27d-7998-b73c-5552c40b436f@gmail.com> (raw)
In-Reply-To: <20210105223955.63678-1-alx.manpages@gmail.com>

Hi Alex,

On 1/5/21 11:39 PM, Alejandro Colomar wrote:
> - Group macros by kinds.
> - Align so that it's easiest to distinguish differences
>   between related macros.
>   (Align all continuations for consistency on PDF.)

(Thanks.)

> - Fix minor typos.
> - Remove redundant text:
>     'The macro xxx() ...':
>         The first paragraph already says that these are macros.
>     'circular|tail|... queue':
>         Don't need to repeat every time.
>         Generic text makes it easier to spot the differences.
> - Fit lines into 78 columns.
> - Reorder descriptions to match SYNOPSIS,

Thanks!

>   and add subsections to DESCRIPTION.

That really helps!

> - srcfix: fix a few smantic newlines.
> 
> I noticed a bug which should be fixed next:
> CIRCLEQ_LOOP_*() return a 'struct TYPE *'.
> 
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Nice work! Patch applied.

Thanks,

Michael

[...]

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  parent reply	other threads:[~2021-01-06 11:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 22:45 [PATCH] circleq.3, list.3, slist.3, stailq.3, tailq.3: Improve readability, especially in SYNOPSIS Alejandro Colomar
2021-01-04 23:05 ` Alejandro Colomar (man-pages)
2021-01-05 13:25   ` Michael Kerrisk (man-pages)
2021-01-05 22:39     ` [PATCH v2] " Alejandro Colomar
2021-01-05 22:53       ` Alejandro Colomar (man-pages)
2021-01-06 12:54         ` Michael Kerrisk (man-pages)
2021-01-06 11:12       ` Michael Kerrisk (man-pages) [this message]
2021-01-05 12:00 ` [PATCH] " Michael Kerrisk (man-pages)
2021-01-05 14:05   ` pdfman Alejandro Colomar (man-pages)
2021-01-06 11:09     ` pdfman Michael Kerrisk (man-pages)
2024-11-03  5:31       ` pdfman Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=894de45b-b27d-7998-b73c-5552c40b436f@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox