Re: [PATCH] execveat.2: srcfix

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hi Alex,

On 1/1/21 2:49 PM, Alejandro Colomar (man-pages) wrote:
> 
> 
> On 1/1/21 12:41 PM, Michael Kerrisk (man-pages) wrote:
>> On 12/31/20 7:55 PM, Alejandro Colomar (man-pages) wrote:
>>> Hi Michael,
>>>
>>> I'm not sure about some cases, but have a look at this:
>>>
>>> a64l.3: compact
> 
> Oops, I meant s/compact/ffix!!/
> 
> That one made it into the page, so ffix!!

Done.

> 
>>> atan.3: wsfix
> 
> still wsfix: s/( long/(long/

Done.

>>> backtrace.3: compact

Group.

>> bstring.3: compact? (and maybe align names?)
>>
>> Not sure about this one. Nothing done yet.

Still not sure on this one.

>>> catopen.3: compact

Done.

>>> envz_add.3: compact?

Compact is too much, and there's no obvious good grouping.

>>> fseeko.3: compact

I grouped. It's enough, I think.

>>> fts.3: compact (and maybe align?)
>>
>> Not sure about this one. Nothing done yet.

Compact feels too much, and there's no obvious good grouping.

>>> getaddrinfo_a.3: fix alignment (and maybe compact?)
>>
>> Not sure about this one. Nothing done yet.

Group.

> see also getaddrinfo.3

Compact feels too much, and there's no obvious grouping.

>>
>>> getdirentries.3: ffix!
> 
> Fit into 78-col terminal

Done.

>>> getmntent.3: compact
>>
>> Not sure about this one. Nothing done yet.

Compact feels too much, and there's no obvious grouping.

>>> getspnam.3: compact or group
>>
>> Grouped.
> 
> Fix alignment too (*_r functions)

Done.

>>> gsignal.3: group
>>
>> Not sure about that. I'll leave this for now.

Compact feels wrong.

>>> key_setsecret.3: compact
>>
>> Group.

Already okay, I think.

>>> login.3: group
> 
> ffix!!

Done.

> The following may help:
> 
> $ for p in $(git grep -l '.SH SYN' man?); do \
> 	echo "===================== $p"; \
> 	man -l $p  2> /dev/null \
> 	|sed -n '/^SYNOP/,/DESCR/p' \
> 	|sed '/Feat/,$d'; \
>   done \
>   |grep '); *[a-zA-Z_]' \
>   |grep -v -e 'Note:' -e NOTES;
>        int brk(void *addr); void *sbrk(intptr_t increment);
>        set);  ssize_t  pwrite(int  fd,  const  void *buf, size_t
>        long a64l(const char *str64); char *l64a(long value);
>        double fmax(double x, double  y);  float  fmaxf(float  x,
>        float  y);  long  double fmaxl(long double x, long double
>        void  login(const struct utmp *ut); int logout(const char
>               place the result(s); inproc is used to encode  the
>               dress  of  where to place the result(s); inproc is
>               ter(s); procname should return a  pointer  to  its
>               static result(s); inproc is used to decode the pa‐
>               RPC socket(s); rdfds is the  resultant  read  file
>        int wordexp(const char *s, wordexp_t *p, int flags); void
>               sp,MAXUN.UNSIGNED ); where MAXUN.UNSIGNED  is  the
>                                     (SIGEV_THREAD_ID); Linux-specific */

Thanks. I fixed a few things.

>>> malloc_hook.3: compact
>>
>> That feels too busy. No change (yet).

Compact feels wrong, and even grouping feels wrong. The signatures are
already hard to read.

>>> mq_getattr.3: compact and fix alignment
> 
> Fix alignment

Done.

>>> random[_r].3: group or compact
>>
>> Group.
> 
> see random_r.3 too

Grouped.

>>> recno.3: There are no APIs? Why not?

It's a weird page. Probably something should be fixed. But
it's outside scope of this patch.

>>> regex.3: compact?
>>
>> Not sure about this one. Nothing done yet.

Actually, I did group, and I think it's enough.

>>
>>> I didn't read past that.
> 
> Still I didn't read past that :)

;-)

>> Well thanks! What you did read was helpful!
> 
> Thanks!
> 
> I removed from the reply those already fixed,
> so what you see in this email is still pending
> (minus a few that I may have forgotten to remove).

Thanks again, Alex. I've pushed the fixed I made.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/