From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: наб <nabijaczleweli@nabijaczleweli.xyz>
Cc: linux-man@vger.kernel.org
Subject: Re: [PATCH v2 2/4] tee.2: use proper types in example
Date: Mon, 3 Jan 2022 18:27:36 +0100 [thread overview]
Message-ID: <90821738-61de-7993-8382-718d1caf8bbf@gmail.com> (raw)
In-Reply-To: <be236ff0a523fb44c3b88cd9d26c1c1255714725.1641229121.git.nabijaczleweli@nabijaczleweli.xyz>
On 1/3/22 18:03, наб wrote:
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
> The difference is, realistically, negligible, but it does make the code
> look like it came from the 4.3BSD era.
:-)
>
> Comments applied. 1/4 not re-sent since you applied it.
I applied all of v2, and another one to remove an unnecessary 'else'.
Cheers,
Alex
>
> man2/tee.2 | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/man2/tee.2 b/man2/tee.2
> index 14a927c93..9d83ee982 100644
> --- a/man2/tee.2
> +++ b/man2/tee.2
> @@ -164,7 +164,7 @@ int
> main(int argc, char *argv[])
> {
> int fd;
> - int len, slen;
> + ssize_t len, slen;
>
> if (argc != 2) {
> fprintf(stderr, "Usage: %s <file>\en", argv[0]);
> @@ -183,7 +183,6 @@ main(int argc, char *argv[])
> */
> len = tee(STDIN_FILENO, STDOUT_FILENO,
> INT_MAX, SPLICE_F_NONBLOCK);
> -
I removed this change, since I guessed it was a rebase mistake.
> if (len < 0) {
> if (errno == EAGAIN)
> continue;
--
Alejandro Colomar
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
next prev parent reply other threads:[~2022-01-03 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 15:33 [PATCH 1/3] tee.2: ffix наб
2022-01-03 15:34 ` [PATCH 2/3] tee.2: use proper types in example, declare variables at point-of-use наб
2022-01-03 16:25 ` Alejandro Colomar (man-pages)
2022-01-03 15:34 ` [PATCH 3/3] tee.2: always fail after perror(), use for(;;) instead of do{}while(1) наб
2022-01-03 16:40 ` Alejandro Colomar (man-pages)
2022-01-03 17:03 ` [PATCH v2 2/4] tee.2: use proper types in example наб
2022-01-03 17:27 ` Alejandro Colomar (man-pages) [this message]
2022-01-03 17:35 ` наб
2022-01-03 17:51 ` Alejandro Colomar (man-pages)
2022-01-03 17:03 ` [PATCH v2 3/4] tee.2: use for(;;) instead of do{}while(1) наб
2022-01-03 17:03 ` [PATCH v2 4/4] tee.2: always fail after perror() in example наб
2022-01-03 16:49 ` [PATCH 1/3] tee.2: ffix Alejandro Colomar (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90821738-61de-7993-8382-718d1caf8bbf@gmail.com \
--to=alx.manpages@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox