Re: [PATCH v5] grantpt.3: no-op on modern glibc and other UNIXes

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 4180 bytes --]

Hi!

On 2023-07-16 13:55, наб wrote:
[...]

> I read it but didn't really understand what you were saying, since
> you're on record as a text‒text‒text liker.

In this context, I'm not sure if to read that as that being just
emphasis on me being a text liker, which is true-true-true, or if
(more likely) "text" are placeholders for random text, and you claim
that I'm on record liking no spaces between em dashes.  If it's the
latter, I believe I am not, and you might have been confused by some
of those records?  Could you point me to the records?  Maybe I had
some brain-fart and defended that at some point, but I do not like
that style personally.

The reason that I like spaces in (only) one side of em dashes --and I
also like closing em dashes even right before other punctuation-- is
to make parsing the text less complex.  I've seen cases where in a
paragraph, several em-dash asides appear, and it's hard to understand
what is the main text and what are the asides, especially when the
closing em dash of one of them is omitted.

Basically, it is something similar to why we should write punctuation
outside of quotes, unless they belong to them, so if I quote someone
who said "Hello world!", I include '!' in the quote, as it belongs to
the quote, but the ',' belongs to my text.

uri(7) has something about those rules for quotes:

   Writing a URI
       When written, URIs should be placed inside double quotes (e.g.,
       "http://www.kernel.org"), enclosed  in  angle  brackets  (e.g.,
       <http://lwn.net>),  or placed on a line by themselves.  A warn‐
       ing for those who  use  double‐quotes:  never  move  extraneous
       punctuation  (such as the period ending a sentence or the comma
       in a list) inside a URI, since this will change  the  value  of
       the  URI.   Instead, use angle brackets instead, or switch to a
       quoting system that never includes extraneous characters inside
       quotation marks.  This latter system, called the ’new’ or ’log‐
       ical’ quoting system by "Hart’s Rules" and the "Oxford  Dictio‐
       nary  for  Writers and Editors", is preferred practice in Great
       Britain and in various  European  languages.   Older  documents
       suggested  inserting the prefix "URL:" just before the URI, but
       this form has never caught on.

It's not exactly the same for em dashes, but they're both progress
towards a more logical way of punctuating text, which I like.

Cheers,
Alex


> You can trivially continue the lines with \c like the below, but
>   "no-op, with permissions ... on Linux, or an ioctl(2)."
> would probably also work just as well,
> and I leave that to your editorial sensibilities.
> 
>  man3/grantpt.3 | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/man3/grantpt.3 b/man3/grantpt.3
> index a19172a3e..363a7aebd 100644
> --- a/man3/grantpt.3
> +++ b/man3/grantpt.3
> @@ -84,17 +84,15 @@ .SH ATTRIBUTES
>  .ad
>  .sp 1
>  .SH VERSIONS
> -Many systems implement this function via a set-user-ID helper binary
> +Historical systems implemented this function via a set-user-ID helper binary
>  called "pt_chown".
> -On Linux systems with a devpts filesystem (present since Linux 2.2),
> -the kernel normally sets the correct ownership and permissions
> -for the pseudoterminal slave when the master is opened
> -.RB ( posix_openpt (3)),
> -so that nothing must be done by
> -.BR grantpt ().
> -Thus, no such helper binary is required
> -(and indeed it is configured to be absent during the
> -glibc build that is typical on many systems).
> +glibc on Linux before glibc 2.33 could do so as well,
> +in order to support configurations with only BSD pseudoterminals;
> +this support has been removed.
> +On modern systems this is either a no-op\c
> +\[em]with permissions configured on pty allotion, as is the case on Linux\[em]\c
> +or an
> +.BR ioctl (2).
>  .SH STANDARDS
>  POSIX.1-2008.
>  .SH HISTORY

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]