Re: [PATCH 2/4] fts.3: list primary modes first, remove triplicate requirement spiel

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2794 bytes --]

Hi,

Please break this commit into smaller chunks.
I'd like commits that move code to _only_ move code,
and do anything else (adjust style/formatting, remove duplicates, ...) 
in a subsequent patch.
See also: 
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html#style-check-your-changes>

It's hard for me to read this patch as is.  Sorry :/

Cheers,

Alex

On 7/4/22 00:23, наб wrote:
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>   man3/fts.3 | 56 +++++++++++++++++++-----------------------------------
>   1 file changed, 20 insertions(+), 36 deletions(-)
> 
> diff --git a/man3/fts.3 b/man3/fts.3
> index bf3e075f2..44465b815 100644
> --- a/man3/fts.3
> +++ b/man3/fts.3
> @@ -376,12 +376,6 @@ The options are selected by ORing
>   the following values:
>   .\" .Bl -tag -width "FTS_PHYSICAL"
>   .TP
> -.B FTS_COMFOLLOW
> -This option causes any symbolic link specified as a root path to be
> -followed immediately whether or not
> -.B FTS_LOGICAL
> -is also specified.
> -.TP
>   .B FTS_LOGICAL
>   This option causes the
>   fts routines to return
> @@ -398,14 +392,27 @@ field is obtained via
>   .BR stat (2)
>   with a fallback to
>   .BR lstat (2).
> -Either
> -.B FTS_LOGICAL
> -or
> +.TP
>   .B FTS_PHYSICAL
> -.I must
> -be provided to the
> -.BR fts_open ()
> -function.
> +This option causes the
> +fts routines to return
> +.I FTSENT
> +structures for symbolic links themselves instead
> +of the target files they point to.
> +If this option is set,
> +.I FTSENT
> +structures for all symbolic links in the
> +hierarchy are returned to the application:
> +the
> +.I fts_statp
> +is obtained via
> +.BR lstat (2).
> +.TP
> +.B FTS_COMFOLLOW
> +This option causes any symbolic link specified as a root path to be
> +followed immediately, as if via
> +.BR FTS_LOGICAL ,
> +regardless of the primary mode.
>   .TP
>   .B FTS_NOCHDIR
>   As a performance optimization, the
> @@ -439,29 +446,6 @@ and leave the contents of the
>   .I statp
>   field undefined.
>   .TP
> -.B FTS_PHYSICAL
> -This option causes the
> -fts routines to return
> -.I FTSENT
> -structures for symbolic links themselves instead
> -of the target files they point to.
> -If this option is set,
> -.I FTSENT
> -structures for all symbolic links in the
> -hierarchy are returned to the application:
> -the
> -.I fts_statp
> -is obtained via
> -.BR lstat (2).
> -Either
> -.B FTS_LOGICAL
> -or
> -.B FTS_PHYSICAL
> -.I must
> -be provided to the
> -.BR fts_open ()
> -function.
> -.TP
>   .B FTS_SEEDOT
>   By default, unless they are specified as path arguments to
>   .BR fts_open (),

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]