Re: [PATCH] strftime.3: mention strftime_l() with .so link

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2151 bytes --]

 > mention strftime_l() with .so link

Mention? really?

That's the most downplaying word for describing the addition of full 
documentation for a function. xD

Also, please add the link page name to the list of affecteed pages:
strftime.3, strftime_l.3: ...

You can use the $(man_gitstaged) bash function from ./scripts/ to 
produce your git messages.  I typically use it as:

git commit -sm "$(man_gitstaged): Description goes here"

I appended the following to my .bash_aliases:

if [ -f ~/src/linux/man-pages/man-pages/scripts/bash_aliases ]; then
	. ~/src/linux/man-pages/man-pages/scripts/bash_aliases;
fi;


On 7/19/22 20:48, наб wrote:
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>   man3/strftime.3   | 27 ++++++++++++++++++++++++++-
>   man3/strftime_l.3 |  1 +
>   2 files changed, 27 insertions(+), 1 deletion(-)
>   create mode 100644 man3/strftime_l.3
> 
> diff --git a/man3/strftime.3 b/man3/strftime.3
> index dc98a5122..11da7e787 100644
> --- a/man3/strftime.3
> +++ b/man3/strftime.3
[...]
> @@ -516,14 +535,20 @@ lbx lb lb
>   l l l.
>   Interface	Attribute	Value
>   T{
> -.BR strftime ()
> +.BR strftime (),
> +.BR strftime_l ()
>   T}	Thread safety	MT-Safe env locale
>   .TE
>   .hy
>   .ad
>   .sp 1
>   .SH CONFORMING TO
> +.BR strftime ():
>   SVr4, C89, C99.
> +.br

Prefer .PP

We avoid raw roff requests in man(7) pages as much as possible.
I'd tell you how to get the same behavior with rare man(7) macros, but I 
don't think we need to complicate it, when .PP is also nice here.
But just for you to know, there's .PD 0 in man(7).


Cheers,

Alex

> +.BR strftime_l ():
> +POSIX.1-2008.
> +.PP
>   .\" FIXME strftime() is in POSIX.1-2001 and POSIX.1-2008, but the details
>   .\" in the standards changed across versions. Investigate and
>   .\" write up.
> diff --git a/man3/strftime_l.3 b/man3/strftime_l.3
> new file mode 100644
> index 000000000..a3aa4b41c
> --- /dev/null
> +++ b/man3/strftime_l.3
> @@ -0,0 +1 @@
> +.so man3/strftime.3

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]