Re: [PATCH] fanotify.7: fix outdated description

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hello Jan,

On 1/4/21 12:55 PM, Jan Kara wrote:
> On Wed 30-12-20 15:17:29, Michael Kerrisk (man-pages) wrote:
>> On 11/26/20 2:29 PM, Jan Kara wrote:
>>> On Thu 26-11-20 10:48:09, Michael Kerrisk (man-pages) wrote:
>>>> On 11/24/20 4:21 PM, Amir Goldstein wrote:
>>>>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>>>>> ---
>>>>>  man7/fanotify.7 | 7 ++++---
>>>>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/man7/fanotify.7 b/man7/fanotify.7
>>>>> index c4f5397e4..5804a1f30 100644
>>>>> --- a/man7/fanotify.7
>>>>> +++ b/man7/fanotify.7
>>>>> @@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
>>>>>  The fanotify API provides notification and interception of
>>>>>  filesystem events.
>>>>>  Use cases include virus scanning and hierarchical storage management.
>>>>> -Currently, only a limited set of events is supported.
>>>>> -In particular, there is no support for create, delete, and move events.
>>>>> +In the original fanotify API, only a limited set of events was supported.
>>>>> +In particular, there was no support for create, delete, and move events.
>>>>> +The support for those events was added in Linux 5.1.
>>>>>  (See
>>>>>  .BR inotify (7)
>>>>> -for details of an API that does notify those events.)
>>>>> +for details of an API that did notify those events pre Linux 5.1.)
>>>>>  .PP
>>>>>  Additional capabilities compared to the
>>>>>  .BR inotify (7)
>>>>
>>>> Thanks, Amir. Applied, with Jan's Reviewed-by.
>>>>
>>>> By the way, I see that there's still no documentation for
>>>> FAN_AUDIT/FAN_ENABLE_AUDIT, added in:
>>>>
>>>>     commit de8cd83e91bc3ee212b3e6ec6e4283af9e4ab269
>>>>     Author: Steve Grubb <sgrubb@redhat.com>
>>>>     Date:   Mon Oct 2 20:21:39 2017 -0400
>>>>
>>>>         audit: Record fanotify access control decisions
>>>>
>>>>
>>>> Can anyone help with that?
>>>
>>> Thanks for a notification. If Steve doesn't beat me to it, I'll write the
>>> doc likely next week.
>>
>> Ping!
> 
> I've already sent it and Steve has acked it [1]. So the ball is on your
> side ;).
> 
> 								Honza
> 
> [1] https://lore.kernel.org/linux-man/4619055.31r3eYUQgx@x2

I was slightly confused because you mentioned in that thread
that you might revise the patych after the comments from Alex.

Anyway, I applied now, and did some light editing. Thank you 
for the patch!

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/