Re: Garbled text in zic(8) man page

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3177 bytes --]

Hi Jonathan, Paul,

On 11/22/22 21:31, Jonathan Wakely wrote:
> On Tue, 22 Nov 2022 at 19:22, Alejandro Colomar wrote:
>>
>> Hi Jonathan,
>>
>> On 11/22/22 14:13, Jonathan Wakely wrote:
>>> On Tue, 22 Nov 2022 at 13:00, Jonathan Wakely wrote:
>>>>
>>>> On Tue, 22 Nov 2022 at 12:58, Jonathan Wakely wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> The description of the RULES field of a Zone line at:
>>>>> https://man7.org/linux/man-pages/man8/zic.8.html#FILES
>>>>> seems garbled:
>>>>> "giving of the amount of time to be added to local standard time effect"
>>>>>
>>>>> It looks like it might be a copy&paste error from the similar text for
>>>>> the SAVE field of a Rule line. I think the first "of" and the "effect"
>>>>> should be removed, but I'm not sure if that's correct.
>>>>
>>>> This was introduced by
>>>> https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man8/zic.8?id=5355e20f816e1e0af93d6bb80439e86f2d1c7be7
>>>> so maybe it should be reported to tzdb upstream instead.
>>>
>>> It's already fixed upstream. The version in the tzdb-2022f package says:
>>>
>>>          RULES The name of the rules that apply in the timezone or,
>>>                alternatively, a field in the same format as a rule-line SAVE
>>>                column, giving the amount of time to be added to local standard
>>>                time and whether the resulting time is standard or daylight
>>>                saving.  If this field is - then standard time always applies.
>>>                When an amount of time is given, only the sum of standard time
>>>                and this amount matters.
>>>
>>> So here's a patch for the man page. There are lots of other changes in
>>> the upstream page though, so another sync might be useful.
>>
>> As you said, a sync would be better.  However, I don't know how Michael did
>> that.
> 
> Paul Eggert did it last time.

Thanks!

> 
>> If you know where the page comes from, could you please prepare a patch
>> that does the sync, and document it in the commit message so that it's easier to
>> do it in the future?
> 
> Upstream is https://www.iana.org/time-zones

Ahh, I remember last time I wanted to check the source code I desisted because 
there's no git repository, and I didn't want to be messing with tarballs.  But 
getting the pages from the tarball seems easy, so I'll do that.

Paul, do you have a public git (or whatever) repository that I can check out?

Thanks,

Alex

> 
> 
>>
>> If you do that, please also sync tzfile(5) and zdump(8) in the commit.
>>
>> Thanks,
>>
>> Alex
>>
>>
>> ---
>>
>> $ cat MAINTAINER_NOTES
>> Externally generated pages
>> ==========================
>>
>> A few pages come from external sources. Fixes to the pages should really
>> go to the upstream source.
>>
>> tzfile(5), zdump(8), and zic(8) come from the tz project
>> (https://www.iana.org/time-zones).
>>
>> bpf-helpers(7) is autogenerated from the kernel sources using scripts.
>> See man-pages commits 53666f6c3 and 19c7f7839 for details.
>>
>> --
>> <http://www.alejandro-colomar.es/>
> 

-- 
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]