Re: [PATCH (2) 33/34] inotify.7: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-04T18:10:30Z

Hello Alex,

I noticed that you sometimes split out several patches to the same
page. Thanks for doing that. As you realize sometimes, there might
be differnt decisions for different patches to the same page.

On 9/4/20 5:07 PM, Alejandro Colomar wrote:
>>From 0d4adf855466fe5c36e378eb704abafd45fc6417 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:59:11 +0200
> Subject: [PATCH 33/34] inotify.7: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>

The above said, I'm also not inclined to apply this patch. Watch
descriptors are by definition 'int', so I don't think this change
improves readability. I think I won't apply this.

Cheers,

Michael

> ---
> man7/inotify.7 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man7/inotify.7 b/man7/inotify.7
> index 4093bba5a..f1a1667e3 100644
> --- a/man7/inotify.7
> +++ b/man7/inotify.7
> @@ -1031,7 +1031,7 @@ main(int argc, char* argv[])
>
> /* Allocate memory for watch descriptors */
>
> - wd = calloc(argc, sizeof(int));
> + wd = calloc(argc, sizeof(*wd));
> if (wd == NULL) {
> perror("calloc");
> exit(EXIT_FAILURE);
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/