Re: [PATCH (2) 19/34] malloc_info.3: Use sizeof consistently

Michael Kerrisk (man-pages)
2020-09-04T15:27:25Z

Hello Alex,

On 9/4/20 4:41 PM, Alejandro Colomar wrote:
>>From bf1a7799161fe1f08570c4f25d87a0f4e0b51ef1 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@gmail.com>
> Date: Thu, 3 Sep 2020 21:49:17 +0200
> Subject: [PATCH 19/34] malloc_info.3: Use sizeof consistently
>
> Use ``sizeof`` consistently through all the examples in the following
> way:
>
> - Use the name of the variable instead of its type as argument for
> ``sizeof``.
>
> Rationale:
> https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory
>
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>

Thanks. Patch applied.

Cheers,

Michael

> ---
> man3/malloc_info.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/malloc_info.3 b/man3/malloc_info.3
> index 0d95cdff7..598478dcc 100644
> --- a/man3/malloc_info.3
> +++ b/man3/malloc_info.3
> @@ -226,7 +226,7 @@ main(int argc, char *argv[])
> blockSize = atoi(argv[3]);
> sleepTime = (argc > 4) ? atoi(argv[4]) : 0;
>
> - thr = calloc(numThreads, sizeof(pthread_t));
> + thr = calloc(numThreads, sizeof(*thr));
> if (thr == NULL)
> errExit("calloc");
>

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/