Re: [PATCH] bswap.3: Use strtoull() for parsing 64-bit numbers

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hello Jakub,

On 9/11/20 1:44 PM, Jakub Wilk wrote:
> Before, on 32-bit systems:
> 
>     $ ./a.out 0x0123456789abcdef
>     0xffffffff ==> 0xffffffff00000000
> 
> After:
> 
>     $ ./a.out 0x0123456789abcdef
>     0x123456789abcdef ==> 0xefcdab8967452301
> 
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>

Sigh!

Thanks. Patch applied.

Cheers,

Michael

> ---
>  man3/bswap.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man3/bswap.3 b/man3/bswap.3
> index 412e1702f..ce847580a 100644
> --- a/man3/bswap.3
> +++ b/man3/bswap.3
> @@ -72,7 +72,7 @@ main(int argc, char *argv[])
>          exit(EXIT_FAILURE);
>      }
>  
> -    x = strtoul(argv[1], NULL, 0);
> +    x = strtoull(argv[1], NULL, 0);
>      printf("0x%" PRIx64 " ==> 0x%" PRIx64 "\en", x, bswap_64(x));
>  
>      exit(EXIT_SUCCESS);
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/