linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Kerrisk <mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
To: Petr Baudis <pasky-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Marcel Moreaux <marcelm-MO7g/Hy4xaE@public.gmane.org>
Subject: Re: [PATCH] man3/crypt.3: Correct note on key portion significance
Date: Mon, 24 May 2010 07:20:01 +0200	[thread overview]
Message-ID: <AANLkTikiFLwEMWKkkoUOG06ziP4NfpD6QGUBeQ8Dmq2y@mail.gmail.com> (raw)
In-Reply-To: <20100511013550.GD16800-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>

Hello Petr,

On Tue, May 11, 2010 at 3:35 AM, Petr Baudis <pasky-AlSwsSmVLrQ@public.gmane.org> wrote:
> As Marcel Moreaux notes:
>
>> The Linux manpage for crypt()[1] contains the following statement as the
>> last sentence of the NOTES section:
>>
>>     In the SHA implementation the entire key is significant (instead of
>>     only the first 8 bytes in MD5).
>>
>> It should probably say "DES" where it says "MD5" (and maybe "MD5/SHA"
>> where it says "SHA"), because in MD5 password hashing, the entire key is
>> significant, not just the first 8 bytes.
>
> This patch fixes the wording.

Thanks. Applied for 3.25.

Cheers,

Michael


> Signed-off-by: Petr Baudis <pasky-AlSwsSmVLrQ@public.gmane.org>
>
> ---
>
> diff --git a/man3/crypt.3 b/man3/crypt.3
> index 1139792..aeaf873 100644
> --- a/man3/crypt.3
> +++ b/man3/crypt.3
> @@ -217,10 +217,10 @@ SHA-512 | 86 characters
>
>  The characters in "\fIsalt\fP" and "\fIencrypted\fP" are drawn from the set
>  [\fBa\fP\(en\fBzA\fP\(en\fBZ0\fP\(en\fB9./\fP].
> -In the SHA implementation the entire
> +In the MD5 and SHA implementations the entire
>  .I key
>  is significant (instead of only the first
> -8 bytes in MD5).
> +8 bytes in DES).
>  .SH "SEE ALSO"
>  .BR login (1),
>  .BR passwd (1),
>



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface" http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2010-05-24  5:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18 17:17 Small error in crypt() manpage Marcel Moreaux
     [not found] ` <20100418171718.GB25938-9b3RgGIKRfocWVvVuXF20w@public.gmane.org>
2010-05-11  1:35   ` [PATCH] man3/crypt.3: Correct note on key portion significance Petr Baudis
     [not found]     ` <20100511013550.GD16800-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
2010-05-24  5:20       ` Michael Kerrisk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikiFLwEMWKkkoUOG06ziP4NfpD6QGUBeQ8Dmq2y@mail.gmail.com \
    --to=mtk.manpages-gm/ye1e23mwn+bqq9rbeug@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marcelm-MO7g/Hy4xaE@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=pasky-AlSwsSmVLrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).