From: Nikos Mavrogiannopoulos <nmav@redhat.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
Florian Weimer <fweimer@redhat.com>,
Zack Weinberg <zackw@panix.com>, Rical Jasan <rj@2c3t.io>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] crypt.3, encrypt.3: Add notes about _XOPEN_CRYPT.
Date: Sat, 14 Apr 2018 21:11:25 +0200 [thread overview]
Message-ID: <CADh2w8SLYdUqLGak6tcpeO2=nMsDGE10BMDMb4q+2Py9tHaOdw@mail.gmail.com> (raw)
In-Reply-To: <640a98e3-ab5f-472b-adfe-db0b0ae5cfc7@gmail.com>
On Fri, Apr 13, 2018 at 9:24 PM, Michael Kerrisk (man-pages)
<mtk.manpages@gmail.com> wrote:
>
> On 04/13/2018 05:10 PM, Carlos O'Donell wrote:
> > On 04/12/2018 02:05 PM, Carlos O'Donell wrote:
> >> +.BR _XOPEN_CRPYT
> >
> > s/CRPYT/CRYPT/g
> >
> > Which I missed in the spell checker due to my overzealous use of ignore.
> >
> > Caught by Nikos Mavrogiannopoulos <nmavrogi@redhat.com> during review.
>
> Thanks. Fixed!
[re-sending in non-html]
Hi Michael,
What about the second part of the suggestion. The crypt.3 manpage
currently suggests including <unistd.h>, with _XOPEN_SOURCE defined,
and that does not work with current glibc. Wouldn't it make sense to
switch to <crypt.h>?
regards,
Nikos
next prev parent reply other threads:[~2018-04-14 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 19:05 [PATCH 2/2] crypt.3, encrypt.3: Add notes about _XOPEN_CRYPT Carlos O'Donell
2018-04-13 9:34 ` Michael Kerrisk (man-pages)
2018-04-13 13:22 ` Carlos O'Donell
2018-04-13 15:10 ` Carlos O'Donell
2018-04-13 19:24 ` Michael Kerrisk (man-pages)
2018-04-14 19:11 ` Nikos Mavrogiannopoulos [this message]
2018-04-14 19:56 ` Florian Weimer
2018-04-16 1:35 ` Zack Weinberg
2018-04-17 13:25 ` Nikos Mavrogiannopoulos
2018-04-17 13:31 ` Florian Weimer
2018-04-14 4:43 ` Rical Jasan
2018-04-14 5:39 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADh2w8SLYdUqLGak6tcpeO2=nMsDGE10BMDMb4q+2Py9tHaOdw@mail.gmail.com' \
--to=nmav@redhat.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rj@2c3t.io \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox