[PATCH] memcmp.3: wfix

[PATCH] memcmp.3: wfix

[Tom Schwindl]

Signed-off-by: Tom Schwindl <schwindl@posteo.de>
---
 man3/memcmp.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/memcmp.3 b/man3/memcmp.3
index c2427a00ac12..26aeaa439e78 100644
--- a/man3/memcmp.3
+++ b/man3/memcmp.3
@@ -73,7 +73,7 @@ Instead, a function that performs comparisons in constant time is required.
 Some operating systems provide such a function (e.g., NetBSD's
 .BR consttime_memequal ()),
 but no such function is specified in POSIX.
-On Linux, it may be necessary to implement such a function oneself.
+On Linux, it may be necessary to implement such a function yourself.
 .SH SEE ALSO
 .BR bstring (3),
 .BR strcasecmp (3),
-- 
2.39.1

Re: [PATCH] memcmp.3: wfix

[G. Branden Robinson]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

At 2023-02-15T13:07:50+0000, Tom Schwindl wrote:
> -On Linux, it may be necessary to implement such a function oneself.
> +On Linux, it may be necessary to implement such a function yourself.

The existing language is sound.  What is the motivation for the change?

Regards,
Branden

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] memcmp.3: wfix

[Tom Schwindl]

On Wed Feb 15, 2023 at 4:18 PM CET, G. Branden Robinson wrote:
> At 2023-02-15T13:07:50+0000, Tom Schwindl wrote:
> > -On Linux, it may be necessary to implement such a function oneself.
> > +On Linux, it may be necessary to implement such a function yourself.
>
> The existing language is sound.  What is the motivation for the change?
>
> Regards,
> Branden

From a formal perspective it's probably fine. But as a reader, I think it sounds
wrong. Or at least strange. That may be because I'm not a native speaker, but
neither is the majority of the manpage readers.
I simply think that "yourself" sounds better in this context. That's also the
reason for this patch. I've read the manpage and hesitated for a short moment
which, for me, indicates a poor choice of words. A `grep -i -r oneself` also
only yields a single result, this manpage.

-- 
Best Regards,
Tom Schwindl

Re: [PATCH] memcmp.3: wfix

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 1324 bytes --]

Hi Tom,

On 2/15/23 17:11, Tom Schwindl wrote:
> On Wed Feb 15, 2023 at 4:18 PM CET, G. Branden Robinson wrote:
>> At 2023-02-15T13:07:50+0000, Tom Schwindl wrote:
>>> -On Linux, it may be necessary to implement such a function oneself.
>>> +On Linux, it may be necessary to implement such a function yourself.
>>
>> The existing language is sound.  What is the motivation for the change?
>>
>> Regards,
>> Branden
> 
> From a formal perspective it's probably fine. But as a reader, I think it sounds
> wrong. Or at least strange. That may be because I'm not a native speaker, but
> neither is the majority of the manpage readers.
> I simply think that "yourself" sounds better in this context. That's also the
> reason for this patch. I've read the manpage and hesitated for a short moment
> which, for me, indicates a poor choice of words. A `grep -i -r oneself` also
> only yields a single result, this manpage.

To me, the existing text reads fine.  Maybe it's because in my language
(Spanish), there's a similar expression for oneself, which may not exist
in other languages?

I'd keep it as it, unless I see more similar reports.  Anyway, thanks
for the report!

Cheers,

Alex
> 

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] memcmp.3: wfix

[Jakub Wilk]

* Tom Schwindl <schwindl@posteo.de>, 2023-02-15 13:07:
>-On Linux, it may be necessary to implement such a function oneself.

This sounds awkward to me too.

>+On Linux, it may be necessary to implement such a function yourself.

This is better, but I'd use active voice here:

   On Linux, you may need to implement such a function yourself.

(I'm not a native speaker.)

-- 
Jakub Wilk

Re: [PATCH] memcmp.3: wfix

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 785 bytes --]

Hi Jakub,

On 2/15/23 18:17, Jakub Wilk wrote:
> * Tom Schwindl <schwindl@posteo.de>, 2023-02-15 13:07:
>> -On Linux, it may be necessary to implement such a function oneself.
> 
> This sounds awkward to me too.
> 
>> +On Linux, it may be necessary to implement such a function yourself.
> 
> This is better, but I'd use active voice here:
> 
>    On Linux, you may need to implement such a function yourself.

Seems reasonable.  By using active voice, you make it more personal,
and "yourself" sounds more appropriate than "oneself".

Would any of you please send a patch?

Thanks for the reports!

Cheers,

Alex

> 
> (I'm not a native speaker.)
> 

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH] memcmp.3: wfix

[Tom Schwindl]

Signed-off-by: Tom Schwindl <schwindl@posteo.de>
---
 man3/memcmp.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/memcmp.3 b/man3/memcmp.3
index c2427a00ac12..de712bd0ae13 100644
--- a/man3/memcmp.3
+++ b/man3/memcmp.3
@@ -73,7 +73,7 @@ Instead, a function that performs comparisons in constant time is required.
 Some operating systems provide such a function (e.g., NetBSD's
 .BR consttime_memequal ()),
 but no such function is specified in POSIX.
-On Linux, it may be necessary to implement such a function oneself.
+On Linux, you may need to implement such a function yourself.
 .SH SEE ALSO
 .BR bstring (3),
 .BR strcasecmp (3),
-- 
2.39.1

Re: [PATCH] memcmp.3: wfix

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]

Hi Tom,

On 2/15/23 18:33, Tom Schwindl wrote:
> Signed-off-by: Tom Schwindl <schwindl@posteo.de>

Patch applied.  Thanks!

Cheers,

Alex

> ---
>  man3/memcmp.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man3/memcmp.3 b/man3/memcmp.3
> index c2427a00ac12..de712bd0ae13 100644
> --- a/man3/memcmp.3
> +++ b/man3/memcmp.3
> @@ -73,7 +73,7 @@ Instead, a function that performs comparisons in constant time is required.
>  Some operating systems provide such a function (e.g., NetBSD's
>  .BR consttime_memequal ()),
>  but no such function is specified in POSIX.
> -On Linux, it may be necessary to implement such a function oneself.
> +On Linux, you may need to implement such a function yourself.
>  .SH SEE ALSO
>  .BR bstring (3),
>  .BR strcasecmp (3),

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]