Re: [PATCH v3 5/6] man2/chmod.2: add C digit separators to clarify POSIX feature release dates and long numeric digit strings

["Tom Schwindl" <schwindl@posteo.de>]

Hi Alex,

On Wed Feb 15, 2023 at 10:10 PM CET, Alejandro Colomar wrote:
> Hi Brian,
>
> On 2/15/23 21:17, Brian Inglis wrote:
> > ---
> >  man2/chmod.2 | 30 +++++++++++++++---------------
> >  1 file changed, 15 insertions(+), 15 deletions(-)
> > 
> > diff --git a/man2/chmod.2 b/man2/chmod.2
> > index 8b5db74ed7e3..674b54368314 100644
> > --- a/man2/chmod.2
> > +++ b/man2/chmod.2
> > @@ -37,7 +37,7 @@ Feature Test Macro Requirements for glibc (see
> >  .nf
> >  .BR fchmod ():
> >      Since glibc 2.24:
> > -        _POSIX_C_SOURCE >= 199309L
> > +        _POSIX_C_SOURCE >= 1993\[aq]09L
>
> Please keep all POSIX dates in a single separate patch
> (unless there's another reason that I'm not seeing).

As long as I'm not completely lost, those values are often passed on the command
line via `-D`. Wouldn't a random \[aq] interfere with shell quoting and result in
hard to find bugs and unexpected bahavior? So is it really a good idea to present
those values in such a way in the manpage? Or am I simply underestimating the
intelligence of the readers? :-)

-- 
Best Regards,
Tom Schwindl

>
> Cheers,
>
> Alex