Re: [PATCH 2/3] landlock.7: Document Landlock ABI v2 (file reparenting; kernel 5.19)

["Günther Noack" <gnoack3000@gmail.com>]

Hello Alex!

Thank you for the review! Please see answers inline:

On Sat, Feb 25, 2023 at 12:21:43AM +0100, Alex Colomar wrote:
> On 2/21/23 21:50, Günther Noack wrote:
> Please have a look at man-pages(7):
>    Use semantic newlines
>        [...]
> 
> Here,
> that would mean
> breaking the line right before the opening parenthesis;
> please also apply it to the rest of the patch where appropriate.

Thanks,
I applied this
so that the text is properly formatted now,
according to man-pages(7).

> > +.IP \(bu 3
> 
> We now use \[bu] instead of \(bu (they are equivalent).

Thanks, applied.

> 80 columns is a strong limit.
> Using semantic newlines as suggested above should fix this.

Done.

> > +.TS
> > +box;
> > +ntb| ntb| lbx
> > +nt| nt| lbx.
> > +ABI	Kernel	Newly introduced access rights
> > +_	_	_
> > +1	5.13	LANDLOCK_ACCESS_FS_EXECUTE
> > +\^	\^	LANDLOCK_ACCESS_FS_WRITE_FILE
> 
> What character do you want here?
> If you want ASCII 0x5E,
> then you want to use \[ha].

I don't want it to show a character there.  The intent is to make the
table cells for ABI version and kernel version span across multiple
rows, for the case where a single kernel version introduced multiple
access rights at once.  \^ is a data item in the tbl(1) syntax which
has that special meaning.

https://manpages.debian.org/testing/groff-base/tbl.1.en.html

    A data item consisting only of ‘\^’ indicates that the field
    immediately above spans downward over this row.

> > +\^	\^	LANDLOCK_ACCESS_FS_READ_FILE
> > +\^	\^	LANDLOCK_ACCESS_FS_READ_DIR
> > +\^	\^	LANDLOCK_ACCESS_FS_REMOVE_DIR
> > +\^	\^	LANDLOCK_ACCESS_FS_REMOVE_FILE
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_CHAR
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_DIR
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_REG
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_SOCK
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_FIFO
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_BLOCK
> > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_SYM
> > +_	_	_
> > +2	5.19	LANDLOCK_ACCESS_FS_REFER

Thanks for the review!
–Günther