Re: [PATCH 3/3] landlock.7: Document Landlock ABI v3 (file truncation; kernel 6.2)

["Günther Noack" <gnoack3000@gmail.com>]

On Sat, Feb 25, 2023 at 12:31:38AM +0100, Alex Colomar wrote:
> On 2/21/23 21:50, Günther Noack wrote:
> > +Open a file with write access. Note that you might additionally need the
> 
> Again,
> please use semantic newlines.
> 
> Also,
> roff(7) requires two spaces after period in source code,
> to detect sentence endings.
> I say this as a curiosity,
> since due to the requirement of semantic newlines,
> we always write a newline after period.

Applied semantic newlines.  There are no single-space sentence ends left.

> > +Whether an opened file can be truncated with
> > +.BR ftruncate (2)
> > +is determined during
> > +.BR open (2),
> > +in the same way as read and write permissions are checked during
> > +.BR open (2)
> > +using
> > +.B LANDLOCK_ACCESS_FS_READ_FILE
> > +and
> > +.BR LANDLOCK_ACCESS_FS_WRITE_FILE .
> > +This access right is available since the third version of the Landlock ABI.
> 
> Maybe it's simpler to say Landlock ABI v3?  That's usual convention in
> software, so not using formal English for that is not a crime :).

Hm, I took that sentence from the kernel documentation,
and I would like to avoid deviating in minor wording aspects.
https://docs.kernel.org/userspace-api/landlock.html

I would be in favor of "ABI v3" as well though, for brevity.
Mickaël, do you have a strong opinion on this?

Thank you for the review!
–Günther