From: Tycho Andersen <tycho@tycho.pizza>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: Alejandro Colomar <alx@kernel.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org
Subject: Re: [PATCH] socket.7: be explicit that connect(2) respects SO_*TIMEO
Date: Sun, 11 Dec 2022 08:59:10 -0700 [thread overview]
Message-ID: <Y5X+Tq25nxFVTroL@tycho.pizza> (raw)
In-Reply-To: <a796c0f9-a4bf-bc5d-3953-9c725b53d10e@gmail.com>
On Fri, Dec 09, 2022 at 09:37:35PM +0100, Alejandro Colomar wrote:
> Hi Tycho,
>
> On 11/28/22 21:58, Tycho Andersen wrote:
>
> So, yes, I like your patch. So, patch applied.
Thanks!
> >
> > Test program for grins:
> >
> > #include <stdio.h>
> > #include <sys/socket.h>
> > #include <netinet/ip.h>
> > #include <arpa/inet.h>
>
> BTW, I'm curious, how did you get the headers in the commit
> message? I always have a space before the # to avoid git
> doing harmful stuff.
I have,
[commit]
cleanup=scissors
in my ~/.gitconfig, which makes it so that the #s are literals.
According to the man page you can also set core.commentChar to
something else if you like that instead.
> P.S.: I don't know if you could please review some patches
> about which you may be more familiar than I am. The are
> somewhat related to this. They are here:
>
> <https://lore.kernel.org/linux-man/20221122153027.10943-1-henri.van.de.water@xs4all.nl/T/#t>
> <https://lore.kernel.org/linux-man/2d4d8b7b-5890-cd9f-061d-6d259d8ed6ee@xs4all.nl/T/#t>
Sure, I'm traveling now but will take a look this week.
Tycho
next prev parent reply other threads:[~2022-12-11 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 20:58 [PATCH] socket.7: be explicit that connect(2) respects SO_*TIMEO Tycho Andersen
2022-12-09 20:37 ` Alejandro Colomar
2022-12-09 23:51 ` Luis Javier Merino
2022-12-11 14:01 ` Alejandro Colomar
2022-12-11 15:59 ` Tycho Andersen [this message]
2023-04-07 23:53 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5X+Tq25nxFVTroL@tycho.pizza \
--to=tycho@tycho.pizza \
--cc=alx.manpages@gmail.com \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox