Re: [PATCH 1/1] man2/fallocate.2: tfix documentation of shared blocks

Darrick J. Wong
2021-06-21T04:25:52Z

On Sun, Jun 20, 2021 at 08:44:53PM -0400, Dan Robertson wrote:
> Fix a typo in the documentation of using fallocate to allocate shared
> blocks. The flag FALLOC_FL_UNSHARE should instead be documented as
> FALLOC_FL_UNSHARE_RANGE.
>
> Fixes: 07c7a6a35497 ("man2/fallocate.2: Document behavior with shared blocks")
> Signed-off-by: Dan Robertson <dan@dlrobertson.com>

Definitely an artifact of unshare being added and removed repeatedly
during the development of XFS reflink. Thanks for fixing this...

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
> man2/fallocate.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/fallocate.2 b/man2/fallocate.2
> index a62706193..b4cb3516f 100644
> --- a/man2/fallocate.2
> +++ b/man2/fallocate.2
> @@ -81,7 +81,7 @@ Preallocating zeroed blocks beyond the end of the file in this manner
> is useful for optimizing append workloads.
> .PP
> If the
> -.B FALLOC_FL_UNSHARE
> +.B FALLOC_FL_UNSHARE_RANGE
> flag is specified in
> .IR mode ,
> shared file data extents will be made private to the file to guarantee