Re: [PATCH 0/1] man2/fallocate.2: Fix documentation of shared blocks

Alejandro Colomar (man-pages)
2021-07-03T18:18:53Z

Hi Dan,

On 6/21/21 2:44 AM, Dan Robertson wrote:
> While doing some work on fallocate for bcachefs I think I stumbled on a
> typo in the fallocate man page. FALLOC_FL_UNSHARE should be
> FALLOC_FL_UNSHARE_RANGE. I believe this is a typo instead of an update
> as a brief look at git history in the kernel seems to indicate that the
> flag was never previously FALLOC_FL_UNSHARE.
>
> If I missed something in my review of history, please let me know. Any
> feedback would be welcome :)

You seem to be correct. There are 2 commits that talk about
FALLOC_FL_UNSHARE, but it seems that they do so for simplicity, and the
code only contains FALLOC_FL_UNSHARE_RANGE.

I applied the patch.

Thanks,

Alex

>
> Dan Robertson (1):
> man2/fallocate.2: tfix documentation of shared blocks
>
> man2/fallocate.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/