Re: [PATCH 1/1] man2/fallocate.2: tfix documentation of shared blocks

Alejandro Colomar (man-pages)
2021-07-03T21:31:36Z

Hi Dan,

On 7/3/21 10:09 PM, Dan Robertson wrote:
> On Sat, Jul 03, 2021 at 08:26:26PM +0200, Alejandro Colomar (man-pages) wrote:
>> Hi Dan,
>>
>>> On Sun, Jun 20, 2021 at 08:44:53PM -0400, Dan Robertson wrote:
>>>> Fix a typo in the documentation of using fallocate to allocate shared
>>>> blocks. The flag FALLOC_FL_UNSHARE should instead be documented as
>>>> FALLOC_FL_UNSHARE_RANGE.
>>>>
>>>> Fixes: 07c7a6a35497 ("man2/fallocate.2: Document behavior with shared blocks")
>>
>> BTW, I can't find that commit hash in git. I have that commit as
>> 63a599c657d8.
>>
>> However, git doesn't fail... It's weird. Could you confirm that?
>
> Gah! You are correct. My bad. I used copied the commit hash for the commit in
> the kernel that introduced the FALLOC_FL_UNSHARE_RANGE flag. My bad.

I thought so, but I couldn't find that commit in Linus' tree either :/

[
.../linux$ git log -1 07c7a6a35497
fatal: ambiguous argument '07c7a6a35497': unknown revision or path not
in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
.../linux$ git log -1 07c7a6a35497 --
fatal: bad revision '07c7a6a35497'
.../linux$ cd ../man-pages/
.../man-pages$ git log -1 07c7a6a35497
.../man-pages$ git log -1 07c7a6a35497 --
.../man-pages$
]

I can't understand that. It fails in the kernel tree, but not in the
man-pages tree. But it doesn't find it in either.

It doesn't matter, but I'm curious...

> I can
> submit a second version of the patch with the correct commit hash if you'd like.

No, don't worry; I fixed it.

>
>>
>> Thanks,
>>
>> Alex
>>
>> --
>> Alejandro Colomar
>> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
>> http://www.alejandro-colomar.es/

--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/