Re: [PATCH 1/1] Document the new fanotify initialization flag FAN_REPORT_PIDFD

[Matthew Bobrowski <repnop@google.com>]

On Sat, Nov 20, 2021 at 02:19:38PM +0200, Amir Goldstein wrote:
> On Wed, Oct 27, 2021 at 12:28 PM Matthew Bobrowski <repnop@google.com> wrote:
> >
> > This provides an explanation on the kind of additional information that can
> > be returned alongside the generic struct fanotify_event_metadata and in
> > what form this additional contextual information is delievered to a
> > listening application.
> >
> > Signed-off-by: Matthew Bobrowski <repnop@google.com>
> > ---
> >  man2/fanotify_init.2 | 54 +++++++++++++++++++++++++
> >  man7/fanotify.7      | 95 +++++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 147 insertions(+), 2 deletions(-)
> >
> > diff --git a/man2/fanotify_init.2 b/man2/fanotify_init.2
> > index 0d83e817f..f65b4fa10 100644
> > --- a/man2/fanotify_init.2
> > +++ b/man2/fanotify_init.2
> > @@ -298,6 +298,60 @@ for additional details.
> >  This is a synonym for
> >  .RB ( FAN_REPORT_DIR_FID | FAN_REPORT_NAME ).
> >  .PP
> > +.TP
> > +.B FAN_REPORT_PIDFD " (since Linux 5.15)"
> 
> Matthew,
> 
> For v2, please document commit id.
> Please also consider including below cleanup patch
> to document commit ids that we missed in v5.9 update.

ACK.

PTAL [0]. BTW, the cleanup patch you referenced appears to be in your
fanotify_unpriv [1] branch, and my fanotify_pidfd_v2 [2] is based off
fanotify_unpriv, so we should be good here.

> 
> --- a/man2/fanotify_init.2
> +++ b/man2/fanotify_init.2
> @@ -213,6 +213,7 @@ See
>  for additional details.
>  .TP
>  .BR FAN_REPORT_DIR_FID " (since Linux 5.9)"
> +.\" commit 83b7a59896dd24015a34b7f00027f0ff3747972f
>  Events for fanotify groups initialized with this flag will contain
>  (see exceptions below) additional information about a directory object
>  correlated to an event.
> @@ -245,6 +246,7 @@ See
>  for additional details.
>  .TP
>  .BR FAN_REPORT_NAME " (since Linux 5.9)"
> +.\" commit 929943b38daf817f2e6d303ea04401651fc3bc05
>  Events for fanotify groups initialized with this flag will contain additional
>  information about the name of the directory entry correlated to an event.
>  This flag must be provided in conjunction with the flag

[0] https://github.com/matthewbobrowski/man-pages/commit/070c144b2f92acffa752ee10ea0c239ee5258b72
[1] https://github.com/amir73il/man-pages/tree/fanotify_unpriv
[2] https://github.com/matthewbobrowski/man-pages/tree/fanotify_pidfd_v2

/M