Re: [PATCH 0/1] fanotify: Document FAN_REPORT_PIDFD Feature

[Matthew Bobrowski <repnop@google.com>]

On Mon, Nov 22, 2021 at 03:37:30PM +0200, Amir Goldstein wrote:
> On Mon, Nov 22, 2021 at 1:19 PM Matthew Bobrowski <repnop@google.com> wrote:
> >
> > On Sat, Nov 20, 2021 at 12:36:26PM +0200, Amir Goldstein wrote:
> > > On Wed, Oct 27, 2021 at 12:28 PM Matthew Bobrowski <repnop@google.com> wrote:
> > > >
> > > > Hi Michael,
> > > >
> > > > This patch series documents the new FAN_REPORT_PIDFD feature that is
> > > > available from v5.15.
> > > >
> > > > Note that this patch series is diffbased against the FANOTIFY_UNPRIV
> > > > [0, 1] man page updates that are yet to be merged with upstream. That
> > > > said, if you could please merge the FANOTIFY_UNPRIV updates first
> > > > followed by the FAN_REPORT_PIDFD updates, that would be much
> > > > appreciated.
> > > >
> > > > [0] https://lore.kernel.org/linux-man/20210318160817.3586288-1-amir73il@gmail.com/
> > > > [1] https://github.com/amir73il/man-pages/commits/fanotify_unpriv
> > > >
> > >
> > > Alejandro,
> > >
> > > Is there any changes of getting those long due 5.13 fanotify update
> > > patches merged?
> > >
> > > Matthew,
> > >
> > > For v2 please base your own fanotify_pidfd branch on top of fanotify_unpriv
> > > (I just rebased it to master again) and provide a branch, that Gabriel
> > > and I could
> > > base the next man page updates on.
> > >
> > > Currently, neither your fanotify_pidfd patch nor Gabriel's fan-fs-error patch
> > > conflict with fanotify_unpriv changes, but fan-fs-error does have conflicts
> > > with fanotify_pidfd.
> >
> > ACK.
> >
> > As per request, v2 of the FAN_REPORT_PIDFD documentation can be found
> > here [0].
> >
> > The branch fanotify_pidfd_v2 is based off your fanotify_unpriv
> > branch. I'd like to post through this series at some point tomorrow,
> > so if you could PTAL in the interim, that'd be appreciated.
> >
> > I've incorporated the explicit documentation of the
> > fanotify_event_info_header structure, rather than duplicating field
> > explanations of such a structure across each information record types
> > as we had discussed.
> >
> > [0] https://github.com/matthewbobrowski/man-pages/tree/fanotify_pidfd_v2
> >
> 
> Hi Mattew,
> 
> I'm basically fine with most of the text in the sections, but
> the sections need some reordering IMO to make more sense.
> High level, I think it should look something like:

Right, I had thought that the ordering might need some work, thanks
for pulling this up.

> - "...the read buffer contains one or more struct fanotify_event_metadata..."
> - Text about several optional information records in event
> - Explain about fanotify_event_info_header and info_type
> - List of fanotify_event_info_* that belong to specific info types
> 
> Commented in github.

OK, I think this will make more sense when I read through the comments
on GitHub. I'll get around to this tonight/tomorrow.

/M