Re: [PATCH v3] fanotify: Document FAN_REPORT_PIDFD Feature

[Matthew Bobrowski <repnop@google.com>]

On Mon, Apr 25, 2022 at 10:18:43PM +0200, Alejandro Colomar wrote:
> Hi Matthew,
> 
> On 4/14/22 01:40, Matthew Bobrowski wrote:
> > Haha, I created this patch using one of Amir's branches, as he
> > performed a rebase and handled some conflicts. It must've preserved
> > the display name "Amir Goldstein" in the "From:" header...
> 
> :)
> 
> > 
> > On Wed, Apr 13, 2022 at 08:24:21PM +0200, Alejandro Colomar wrote:
> > > Hi Amir!
> > > 
> > > On 4/12/22 01:17, Amir Goldstein wrote:
> > > > Update the fanotify API documentation to include details on the new
> > > > FAN_REPORT_PIDFD feature. This patch also includes a generic section
> > > > describing the concept of information records which are supported by
> > > > the fanotify API.
> > > > 
> > > > Signed-off-by: Matthew Bobrowski <repnop@google.com>
> > > > Reviewed-by: Jan Kara <jack@suse.cz>
> > > > Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> > > 
> > > Thanks for the patch.  Please see some comments below.
> > 
> > Thanks for the review, I'll update and send through a follow up patch
> > shortly. I left a question on your comment about the use of semantic
> > newlines. I wasn't sure whether that comment was a general rule that
> > is to be applied across this entire patch (in which it definitely can,
> > I just wasn't aware of the rule prior to you explicitly pointing it
> > out), or whether there was a specific example you were referring to in
> > the code block directly above your comment.
> 
> General rule to be applied across the entire patch, if you do the favour.  I
> just mentioned it at a point where it is clear that it could be applied, to
> give some context.

Fair enough.

I've posted through an updated patch here [0] which I believe has
addressed all the feedback from this round of review.

[0] https://lore.kernel.org/linux-man/1af583adb1f368c51f1976db7bf3a27530cdc06f.1650408011.git.repnop@google.com/

/M