From: Greg KH <gregkh@linuxfoundation.org>
To: "G. Branden Robinson" <g.branden.robinson@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Alejandro Colomar <alx.manpages@gmail.com>,
Quentin Monnet <quentin@isovalent.com>, bpf <bpf@vger.kernel.org>,
linux-man <linux-man@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH] Fit line in 80 columns
Date: Sat, 27 Aug 2022 09:20:07 +0200 [thread overview]
Message-ID: <YwnFp9BKmpi7UXUX@kroah.com> (raw)
In-Reply-To: <20220825225425.hp2ylp5rxq453ewl@illithid>
On Thu, Aug 25, 2022 at 05:54:25PM -0500, G. Branden Robinson wrote:
> [sorry for the big CC]
>
> At 2022-08-25T11:06:55-0700, Alexei Starovoitov wrote:
> > Nack.
> >
> > We don't follow 80 char limit and are not going to because of man
> > pages.
>
> If someone got a contract with O'Reilly or No Starch Press to write a
> book on BPF and how revolutionarily awesome it is, it's conceivable they
> would be faced with exposing some BPF-related function declarations in
> the text. In cases like the following, what would you have them do?
>
> int bpf_map_update_elem(struct bpf_map *map, const void *key, const void *value, u64 flags)
>
> Be aware that the author may not have infinite flexibility; publishers
> generally impose a "house style" which restricts selection of typeface
> (so they can't necessarily print at a smaller type size or with the
> kerning reduced beyond a certain point to squeeze the text onto the
> line).
As someone who has written a book for one of those publishers you
mention above, this is totally not an issue at all. Authors and
typesetters know how to properly wrap and handle stuff like this
automatically, it's what they do and has nothing to do with how kernel
header files are layed out.
But even then, if it was an issue, we don't write kernel code for "some
potential commercial entity that can't handle long lines", you know
better than this :)
greg k-h
next prev parent reply other threads:[~2022-08-27 7:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 17:56 [PATCH] Fit line in 80 columns Alejandro Colomar
2022-08-25 18:06 ` Alexei Starovoitov
2022-08-25 21:36 ` Andrii Nakryiko
2022-08-25 21:51 ` Alejandro Colomar
2022-08-25 21:54 ` Alejandro Colomar
2022-08-25 22:54 ` G. Branden Robinson
2022-08-26 0:25 ` Alexei Starovoitov
2022-08-26 0:45 ` Seth David Schoen
2022-08-27 7:20 ` Greg KH [this message]
2022-08-29 19:58 ` [PATCH v2] Fit lines " Alejandro Colomar
2022-08-29 20:29 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwnFp9BKmpi7UXUX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=alx.manpages@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=g.branden.robinson@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox