From: Petr Vorel <pvorel@suse.cz>
To: Stefan Puiu <stefan.puiu@gmail.com>
Cc: Alejandro Colomar <alx.manpages@gmail.com>,
Jakub Wilk <jwilk@jwilk.net>, lnx-man <linux-man@vger.kernel.org>,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: Revert 70ac1c478 ("src.mk, All pages: Move man* to man/")
Date: Fri, 9 Sep 2022 10:46:16 +0200 [thread overview]
Message-ID: <Yxr9WN7f3FEqKVRg@pevik> (raw)
In-Reply-To: <CACKs7VADwh0Qs8Zo7=biVzpOhSgMt5xD1BSBXdg82sPAcdjYOg@mail.gmail.com>
> Hi Alex,
> On Thu, Sep 8, 2022 at 1:28 AM Alejandro Colomar <alx.manpages@gmail.com> wrote:
> > Hi Jakub
> > On 9/7/22 22:53, Jakub Wilk wrote:
> > > * Petr Vorel <pvorel@suse.cz>, 2022-09-06 11:41:
> > >> Although I agree that number of man* is quite high and single man
> > >> directory looks nicer, from practical reasons I'd prefer to revert
> > >> this commit.
> > > I don't like the new layout either.
> > Thank you both for sharing your opinion. I'll revert it, then. Let me
> > a few weeks before doing that, since I'm in the middle of some other big
> > changes (about lint-c), so to not have to stash and fix conflicts at
> > that scale. If in the meantime someone finds the new layout nice,
> > please speak up :)
> I think one other aspect to consider is that it makes history
> searching harder. If you type 'git log <file>', by default you only
> get the history to the last move. You need 'git log --follow' to see
> the whole history. Then if you want to do a 'git blame' on an old
> version of the file, pre-move, I think you need to find the old path
> and use that. If the maintainer's opinion of where a file should be
> changes often, that makes it more fun :).
Yes, I have experience from other projects that moving around does not help.
But here simple revert is working well:
$ git revert 70ac1c4785fc1e158ab2349a962dba2526bf4fbc
git is smart: new changes in unshare.2 (8f4ed6463) and fanotify_mark.2
(c06943bee) didn't cause a conflict. But still, if you decide on revert, I'd do
it early (don't put new commits before it)
$ git log man2/_exit.2 # shows previous history
Kind regards,
Petr
> Just my 2 cents,
> Stefan.
> > Cheers,
> > Alex
next prev parent reply other threads:[~2022-09-09 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 9:41 Revert 70ac1c478 ("src.mk, All pages: Move man* to man/") Petr Vorel
2022-09-06 11:19 ` Alejandro Colomar
2022-09-06 11:57 ` Alejandro Colomar
2022-09-06 11:58 ` Alejandro Colomar
2022-09-06 16:09 ` Petr Vorel
2022-09-07 20:53 ` Jakub Wilk
2022-09-07 22:11 ` Alejandro Colomar
2022-09-08 12:42 ` Stefan Puiu
2022-09-09 8:46 ` Petr Vorel [this message]
2022-09-15 13:40 ` Alex Colomar
2022-09-15 13:48 ` Petr Vorel
2023-08-02 21:38 ` Alejandro Colomar
2023-08-02 21:45 ` Alejandro Colomar
2024-03-26 1:28 ` Move man* to man/ (was: Revert 70ac1c478 ("src.mk, All pages: Move man* to man/")) Alejandro Colomar
2024-04-26 12:43 ` Ping: " Alejandro Colomar
2024-04-26 18:03 ` Petr Vorel
2024-04-26 20:19 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxr9WN7f3FEqKVRg@pevik \
--to=pvorel@suse.cz \
--cc=alx.manpages@gmail.com \
--cc=jwilk@jwilk.net \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=stefan.puiu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox