From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DDBECAAD3 for ; Fri, 9 Sep 2022 08:46:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231837AbiIIIql (ORCPT ); Fri, 9 Sep 2022 04:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231829AbiIIIqV (ORCPT ); Fri, 9 Sep 2022 04:46:21 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FF3412F233 for ; Fri, 9 Sep 2022 01:46:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 833B422919; Fri, 9 Sep 2022 08:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662713178; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7bwu90PHa6gTJIZsSNZNj3Ydq0/U4E+mHUQFwmfHefw=; b=Unabrp2ChITW8dcdau3W/37K51Fjg1iIELOVp8d+k0F7Sw1jzv92XflLCB/VLrUgBGuz5i 0Cx61DbYmJ/U91DiyikeTvgBHkgTBnpDd0j2+laonfAE+IAUZxWdvfoOsBPEj7sES5uCdK OmfTFPXcUXdC5p9vFpNJQCBbFypojkc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662713178; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7bwu90PHa6gTJIZsSNZNj3Ydq0/U4E+mHUQFwmfHefw=; b=p/by2ffG9pzxyorfF749glj20wQqb92NnpZH0CrBNjzEj+EOT8wmLCaUy3vT7rFlyWqvCW 9jBLFOoS2trcFMCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EDEA139D5; Fri, 9 Sep 2022 08:46:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dyavEVr9GmNHTwAAMHmgww (envelope-from ); Fri, 09 Sep 2022 08:46:18 +0000 Date: Fri, 9 Sep 2022 10:46:16 +0200 From: Petr Vorel To: Stefan Puiu Cc: Alejandro Colomar , Jakub Wilk , lnx-man , Michael Kerrisk Subject: Re: Revert 70ac1c478 ("src.mk, All pages: Move man* to man/") Message-ID: Reply-To: Petr Vorel References: <20220907205304.nlqce37l26gezjqi@jwilk.net> <7b9c2ab4-6cdc-b4fd-1001-8721083695fa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org > Hi Alex, > On Thu, Sep 8, 2022 at 1:28 AM Alejandro Colomar wrote: > > Hi Jakub > > On 9/7/22 22:53, Jakub Wilk wrote: > > > * Petr Vorel , 2022-09-06 11:41: > > >> Although I agree that number of man* is quite high and single man > > >> directory looks nicer, from practical reasons I'd prefer to revert > > >> this commit. > > > I don't like the new layout either. > > Thank you both for sharing your opinion. I'll revert it, then. Let me > > a few weeks before doing that, since I'm in the middle of some other big > > changes (about lint-c), so to not have to stash and fix conflicts at > > that scale. If in the meantime someone finds the new layout nice, > > please speak up :) > I think one other aspect to consider is that it makes history > searching harder. If you type 'git log ', by default you only > get the history to the last move. You need 'git log --follow' to see > the whole history. Then if you want to do a 'git blame' on an old > version of the file, pre-move, I think you need to find the old path > and use that. If the maintainer's opinion of where a file should be > changes often, that makes it more fun :). Yes, I have experience from other projects that moving around does not help. But here simple revert is working well: $ git revert 70ac1c4785fc1e158ab2349a962dba2526bf4fbc git is smart: new changes in unshare.2 (8f4ed6463) and fanotify_mark.2 (c06943bee) didn't cause a conflict. But still, if you decide on revert, I'd do it early (don't put new commits before it) $ git log man2/_exit.2 # shows previous history Kind regards, Petr > Just my 2 cents, > Stefan. > > Cheers, > > Alex